2024-04-23 16:48:41

by Christoph Hellwig

[permalink] [raw]
Subject: xfs fixups for the fop_flags conversion

Hi all,

this series against Christian's vfs.misc branch fixes up pointless
harmless but pointless over-declaration of capabilities for XFS
directories.

Christian: the first patch would make sense to just fold into the
original fop_flags conversion if you're still rebasing the branch.

xfs_file.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)


2024-04-24 03:33:14

by Darrick J. Wong

[permalink] [raw]
Subject: Re: xfs fixups for the fop_flags conversion

On Tue, Apr 23, 2024 at 02:46:05PM +0200, Christoph Hellwig wrote:
> Hi all,
>
> this series against Christian's vfs.misc branch fixes up pointless
> harmless but pointless over-declaration of capabilities for XFS
> directories.
>
> Christian: the first patch would make sense to just fold into the
> original fop_flags conversion if you're still rebasing the branch.

All three patches look good to me,
Reviewed-by: Darrick J. Wong <[email protected]>

--D

>
> xfs_file.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)

2024-04-24 12:49:24

by Christian Brauner

[permalink] [raw]
Subject: Re: xfs fixups for the fop_flags conversion

On Tue, 23 Apr 2024 14:46:05 +0200, Christoph Hellwig wrote:
> this series against Christian's vfs.misc branch fixes up pointless
> harmless but pointless over-declaration of capabilities for XFS
> directories.
>
> Christian: the first patch would make sense to just fold into the
> original fop_flags conversion if you're still rebasing the branch.
>
> [...]

Thanks for the fixes! I didn't fold because it would rebase a lot of
other stuff which I'd like to avoid. :/

---

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/3] xfs: fix overly long line in the file_operations
https://git.kernel.org/vfs/vfs/c/19e048641bc6
[2/3] xfs: drop fop_flags for directories
https://git.kernel.org/vfs/vfs/c/f50805713a6e
[3/3] xfs: don't call xfs_file_open from xfs_dir_open
https://git.kernel.org/vfs/vfs/c/652efdeca5b1