2024-04-24 15:03:59

by Christophe JAILLET

Subject: [PATCH] clk: rockchip: Remove some unused fields in struct rockchip_mmc_clock

In "struct rockchip_mmc_clock", the 'id' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.

Apparently, it has never been used. It is not a left-over from a
refactoring.
---
drivers/clk/rockchip/clk-mmc-phase.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clk/rockchip/clk-mmc-phase.c b/drivers/clk/rockchip/clk-mmc-phase.c
index 975454a3dd72..91012078681b 100644
--- a/drivers/clk/rockchip/clk-mmc-phase.c
+++ b/drivers/clk/rockchip/clk-mmc-phase.c
@@ -14,7 +14,6 @@
struct rockchip_mmc_clock {
struct clk_hw hw;
void __iomem *reg;
- int id;
int shift;
int cached_phase;
struct notifier_block clk_rate_change_nb;
--
2.44.0

2024-05-04 10:51:54

by Heiko Stuebner

Subject: Re: [PATCH] clk: rockchip: Remove some unused fields in struct rockchip_mmc_clock

On Wed, 24 Apr 2024 16:48:29 +0200, Christophe JAILLET wrote:
> In "struct rockchip_mmc_clock", the 'id' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
>

Applied, thanks!

[1/1] clk: rockchip: Remove some unused fields in struct rockchip_mmc_clock
commit: 947b8f2a8b5155f6e9560af07ed65b3cc9aecd75

Best regards,
--
Heiko Stuebner <[email protected]>