2024-04-24 15:30:53

by Xilin Wu via B4 Relay

[permalink] [raw]
Subject: [PATCH 01/10] dt-bindings: pwm: Add SI-EN SN3112 PWM support

From: Junhao Xie <[email protected]>

Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.

Signed-off-by: Junhao Xie <[email protected]>
---
.../devicetree/bindings/pwm/si-en,sn3112-pwm.yaml | 55 ++++++++++++++++++++++
1 file changed, 55 insertions(+)

diff --git a/Documentation/devicetree/bindings/pwm/si-en,sn3112-pwm.yaml b/Documentation/devicetree/bindings/pwm/si-en,sn3112-pwm.yaml
new file mode 100644
index 000000000000..2ab229ac40ce
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/si-en,sn3112-pwm.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/si-en,sn3112-pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SI-EN SN3112 12-channel 8-bit PWM LED controller
+
+maintainers:
+ - Junhao Xie <[email protected]>
+
+allOf:
+ - $ref: pwm.yaml#
+
+properties:
+ compatible:
+ const: si-en,sn3112-pwm
+
+ reg:
+ const: 0x54
+ description: I2C slave address
+
+ sdb-gpios:
+ maxItems: 1
+ description: GPIO pin to hardware shutdown the device.
+
+ vdd-supply:
+ description: Chip vdd supply
+
+ "#pwm-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - "#pwm-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pwm@54 {
+ compatible = "si-en,sn3112-pwm";
+ reg = <0x54>;
+ sdb-gpios = <&pio 1 1 GPIO_ACTIVE_LOW>; /* PA1 */
+ vdd-supply = <&reg_dcdc1>;
+ #pwm-cells = <1>;
+ };
+ };

--
2.44.0




2024-04-25 06:05:39

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH 01/10] dt-bindings: pwm: Add SI-EN SN3112 PWM support

Hello,

On Wed, Apr 24, 2024 at 11:29:06PM +0800, Xilin Wu via B4 Relay wrote:
> From: Junhao Xie <[email protected]>
>
> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.
>
> Signed-off-by: Junhao Xie <[email protected]>

Missing S-o-b for patch submitter.

> + "#pwm-cells":
> + const: 1

please use 3 here (which is also what the driver implements)

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (582.00 B)
signature.asc (499.00 B)
Download all attachments