2024-04-25 01:27:47

by Joy Zou

Subject: [PATCH v5 0/1] Add RTC PCF2131 support

The patchset supports RTC PCF2131 on board dts.
For the details, please check the patch commit log.

Joy Zou (1):
arm64: dts: imx93-11x11-evk: add RTC PCF2131 support

.../boot/dts/freescale/imx93-11x11-evk.dts | 21 +++++++++++++++++++
1 file changed, 21 insertions(+)

--
2.37.1

2024-04-25 01:28:02

by Joy Zou

Subject: [PATCH v5 1/1] arm64: dts: imx93-11x11-evk: add RTC PCF2131 support

Support RTC PCF2131 on imx93-11x11-evk.

Signed-off-by: Joy Zou <[email protected]>
---
Changes in v5:
1.remove pinctrl-1.
2.change rtc into RTC.
3.remove unnecessary cells in order to keep terse.

Changes in v4:
1.remove the sleep from the pinctrl-names.

Changes in v3:
1.adjust the indentation.

Changes in v2:
1.remove unnecessary status property.
---
.../boot/dts/freescale/imx93-11x11-evk.dts | 21 +++++++++++++++++++
1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 07e85a30a25f..11eeaa9d2674 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -281,6 +281,20 @@ ldo5: LDO5 {
};
};

+&lpi2c3 {
+ clock-frequency = <400000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_lpi2c3>;
+ status = "okay";
+
+ pcf2131: rtc@53 {
+ compatible = "nxp,pcf2131";
+ reg = <0x53>;
+ interrupt-parent = <&pcal6524>;
+ interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
+ };
+};
+
&iomuxc {
pinctrl_eqos: eqosgrp {
fsl,pins = <
@@ -343,6 +357,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA 0x40000b9e
>;
};

+ pinctrl_lpi2c3: lpi2c3grp {
+ fsl,pins = <
+ MX93_PAD_GPIO_IO28__LPI2C3_SDA 0x40000b9e
+ MX93_PAD_GPIO_IO29__LPI2C3_SCL 0x40000b9e
+ >;
+ };
+
pinctrl_pcal6524: pcal6524grp {
fsl,pins = <
MX93_PAD_CCM_CLKO2__GPIO3_IO27 0x31e
--
2.37.1

2024-04-25 08:27:37

by Marco Felsch

Subject: Re: [PATCH v5 1/1] arm64: dts: imx93-11x11-evk: add RTC PCF2131 support

On 24-04-25, Joy Zou wrote:
> Support RTC PCF2131 on imx93-11x11-evk.
>
> Signed-off-by: Joy Zou <[email protected]>

Reviewed-by: Marco Felsch <[email protected]>

> ---
> Changes in v5:
> 1.remove pinctrl-1.
> 2.change rtc into RTC.
> 3.remove unnecessary cells in order to keep terse.
>
> Changes in v4:
> 1.remove the sleep from the pinctrl-names.
>
> Changes in v3:
> 1.adjust the indentation.
>
> Changes in v2:
> 1.remove unnecessary status property.
> ---
> .../boot/dts/freescale/imx93-11x11-evk.dts | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> index 07e85a30a25f..11eeaa9d2674 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> @@ -281,6 +281,20 @@ ldo5: LDO5 {
> };
> };
>
> +&lpi2c3 {
> + clock-frequency = <400000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lpi2c3>;
> + status = "okay";
> +
> + pcf2131: rtc@53 {
> + compatible = "nxp,pcf2131";
> + reg = <0x53>;
> + interrupt-parent = <&pcal6524>;
> + interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> + };
> +};
> +
> &iomuxc {
> pinctrl_eqos: eqosgrp {
> fsl,pins = <
> @@ -343,6 +357,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA 0x40000b9e
> >;
> };
>
> + pinctrl_lpi2c3: lpi2c3grp {
> + fsl,pins = <
> + MX93_PAD_GPIO_IO28__LPI2C3_SDA 0x40000b9e
> + MX93_PAD_GPIO_IO29__LPI2C3_SCL 0x40000b9e
> + >;
> + };
> +
> pinctrl_pcal6524: pcal6524grp {
> fsl,pins = <
> MX93_PAD_CCM_CLKO2__GPIO3_IO27 0x31e
> --
> 2.37.1
>
>

2024-04-25 09:59:31

by Shawn Guo

Subject: Re: [PATCH v5 1/1] arm64: dts: imx93-11x11-evk: add RTC PCF2131 support

On Thu, Apr 25, 2024 at 09:35:07AM +0800, Joy Zou wrote:
> Support RTC PCF2131 on imx93-11x11-evk.
>
> Signed-off-by: Joy Zou <[email protected]>

Applied, thanks!