2024-04-25 10:05:15

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] wifi: brcmfmac: remove unused brcmf_usb_image struct

struct brcmf_usb_image was added in the initial commit 71bb244ba2fd5
("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets") and updated
in commit 803599d40418 ("brcmfmac: store usb fw images in local linked
list.")

Its only usage was removed in commit 52f98a57d8c1 ("brcmfmac: remove
firmware list from USB driver").

Remove the structure definition now. This saves a few lines of code.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
index 0ccf735316c2..9a105e6debe1 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
@@ -117,13 +117,6 @@ struct bootrom_id_le {
__le32 boardrev; /* Board revision */
};

-struct brcmf_usb_image {
- struct list_head list;
- s8 *fwname;
- u8 *image;
- int image_len;
-};
-
struct brcmf_usbdev_info {
struct brcmf_usbdev bus_pub; /* MUST BE FIRST */
spinlock_t qlock;
--
2.44.0



2024-04-26 10:36:45

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] wifi: brcmfmac: remove unused brcmf_usb_image struct

Christophe JAILLET <[email protected]> wrote:

> struct brcmf_usb_image was added in the initial commit 71bb244ba2fd5
> ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets") and updated
> in commit 803599d40418 ("brcmfmac: store usb fw images in local linked
> list.")
>
> Its only usage was removed in commit 52f98a57d8c1 ("brcmfmac: remove
> firmware list from USB driver").
>
> Remove the structure definition now. This saves a few lines of code.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> Acked-by: Arend van Spriel <[email protected]>

Patch applied to wireless-next.git, thanks.

cc1380dd1882 wifi: brcmfmac: remove unused brcmf_usb_image struct

--
https://patchwork.kernel.org/project/linux-wireless/patch/23afd8c1733ad087ce2399a07a30d689aef861d5.1714039373.git.christophe.jaillet@wanadoo.fr/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches