2024-05-06 15:16:29

by Johan Hovold

Subject: [PATCH 07/13] mfd: pm8008: drop unused driver data

The i2c client driver data pointer has never been used so drop the
unnecessary assignment.

Signed-off-by: Johan Hovold <[email protected]>
---
drivers/mfd/qcom-pm8008.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index a04bae52a49a..c7a4f8a60cd4 100644
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -169,8 +169,6 @@ static int pm8008_probe(struct i2c_client *client)
if (IS_ERR(regmap))
return PTR_ERR(regmap);

- i2c_set_clientdata(client, regmap);
-
reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
if (IS_ERR(reset))
return PTR_ERR(reset);
--
2.43.2

2024-05-08 17:40:44

by Bryan O'Donoghue

Subject: Re: [PATCH 07/13] mfd: pm8008: drop unused driver data

On 06/05/2024 16:08, Johan Hovold wrote:
> The i2c client driver data pointer has never been used so drop the
> unnecessary assignment.
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
> drivers/mfd/qcom-pm8008.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index a04bae52a49a..c7a4f8a60cd4 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -169,8 +169,6 @@ static int pm8008_probe(struct i2c_client *client)
> if (IS_ERR(regmap))
> return PTR_ERR(regmap);
>
> - i2c_set_clientdata(client, regmap);
> -
> reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
> if (IS_ERR(reset))
> return PTR_ERR(reset);

Reviewed-by: Bryan O'Donoghue <[email protected]>

2024-05-08 22:05:52

by Stephen Boyd

Subject: Re: [PATCH 07/13] mfd: pm8008: drop unused driver data

Quoting Johan Hovold (2024-05-06 08:08:24)
> The i2c client driver data pointer has never been used so drop the
> unnecessary assignment.
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>