2024-05-16 13:34:21

by Dr. David Alan Gilbert

Subject: [PATCH] edac: thunderx: remove unused struct 'error_syndrome'

From: "Dr. David Alan Gilbert" <[email protected]>

'error_syndrome' appears never to have been used.
Remove it, together with the MAX_SYNDROME_REGS it used.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/edac/thunderx_edac.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
index fab9891e569a..75c04dfc3962 100644
--- a/drivers/edac/thunderx_edac.c
+++ b/drivers/edac/thunderx_edac.c
@@ -35,12 +35,6 @@ enum {
ERR_UNKNOWN = 3,
};

-#define MAX_SYNDROME_REGS 4
-
-struct error_syndrome {
- u64 reg[MAX_SYNDROME_REGS];
-};
-
struct error_descr {
int type;
u64 mask;
--
2.45.0

2024-05-27 13:06:04

by Borislav Petkov

Subject: Re: [PATCH] edac: thunderx: remove unused struct 'error_syndrome'

On Thu, May 16, 2024 at 02:34:04PM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'error_syndrome' appears never to have been used.
> Remove it, together with the MAX_SYNDROME_REGS it used.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> drivers/edac/thunderx_edac.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
> index fab9891e569a..75c04dfc3962 100644
> --- a/drivers/edac/thunderx_edac.c
> +++ b/drivers/edac/thunderx_edac.c
> @@ -35,12 +35,6 @@ enum {
> ERR_UNKNOWN = 3,
> };
>
> -#define MAX_SYNDROME_REGS 4
> -
> -struct error_syndrome {
> - u64 reg[MAX_SYNDROME_REGS];
> -};
> -
> struct error_descr {
> int type;
> u64 mask;
> --

Applied, thanks.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette