2024-05-17 12:55:22

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] dt-bindings: soc: bcm: document brcm,bcm2711-avs-monitor

Document alreasdy used binding for Syscon / AVS monitor:
brcm,bcm2711-avs-monitor to fix dt_binding_check and dtbs_check warnings
like:

brcm,avs-ro-thermal.example.dtb: /example-0/avs-monitor@7d5d2000: failed to match any schema with compatible: ['brcm,bcm2711-avs-monitor', 'syscon', 'simple-mfd']

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../soc/bcm/brcm,bcm2711-avs-monitor.yaml | 44 +++++++++++++++++++
1 file changed, 44 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2711-avs-monitor.yaml

diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2711-avs-monitor.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2711-avs-monitor.yaml
new file mode 100644
index 000000000000..e02d9d7e7d9a
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2711-avs-monitor.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/bcm/brcm,bcm2711-avs-monitor.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom AVS Monitor
+
+maintainers:
+ - Stefan Wahren <[email protected]>
+
+properties:
+ compatible:
+ items:
+ - const: brcm,bcm2711-avs-monitor
+ - const: syscon
+ - const: simple-mfd
+
+ reg:
+ maxItems: 1
+
+ thermal:
+ $ref: /schemas/thermal/brcm,avs-ro-thermal.yaml
+ description: Broadcom AVS ring oscillator thermal
+
+required:
+ - compatible
+ - reg
+ - thermal
+
+additionalProperties: false
+
+examples:
+ - |
+ avs-monitor@7d5d2000 {
+ compatible = "brcm,bcm2711-avs-monitor", "syscon", "simple-mfd";
+ reg = <0x7d5d2000 0xf00>;
+
+ thermal: thermal {
+ compatible = "brcm,bcm2711-thermal";
+ #thermal-sensor-cells = <0>;
+ };
+ };
+...
--
2.43.0



2024-05-17 21:27:18

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: bcm: document brcm,bcm2711-avs-monitor

On Fri, May 17, 2024 at 02:51:38PM +0200, Krzysztof Kozlowski wrote:
> Document alreasdy used binding for Syscon / AVS monitor:
> brcm,bcm2711-avs-monitor to fix dt_binding_check and dtbs_check warnings
> like:
>
> brcm,avs-ro-thermal.example.dtb: /example-0/avs-monitor@7d5d2000: failed to match any schema with compatible: ['brcm,bcm2711-avs-monitor', 'syscon', 'simple-mfd']
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../soc/bcm/brcm,bcm2711-avs-monitor.yaml | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2711-avs-monitor.yaml

I was about to start just deleting the remaining examples causing
warnings.

Reviewed-by: Rob Herring <[email protected]>

2024-05-17 23:16:28

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: bcm: document brcm,bcm2711-avs-monitor

From: Florian Fainelli <[email protected]>

On Fri, 17 May 2024 14:51:38 +0200, Krzysztof Kozlowski <[email protected]> wrote:
> Document alreasdy used binding for Syscon / AVS monitor:
> brcm,bcm2711-avs-monitor to fix dt_binding_check and dtbs_check warnings
> like:
>
> brcm,avs-ro-thermal.example.dtb: /example-0/avs-monitor@7d5d2000: failed to match any schema with compatible: ['brcm,bcm2711-avs-monitor', 'syscon', 'simple-mfd']
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian

2024-05-23 07:24:36

by Stefan Wahren

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: bcm: document brcm,bcm2711-avs-monitor

Hi,

Am 17.05.24 um 14:51 schrieb Krzysztof Kozlowski:
> Document alreasdy used binding for Syscon / AVS monitor:
s/alreasdy/already excepted of that: Reviewed-by: Stefan Wahren
<[email protected]> Thanks
> brcm,bcm2711-avs-monitor to fix dt_binding_check and dtbs_check warnings
> like:
>
> brcm,avs-ro-thermal.example.dtb: /example-0/avs-monitor@7d5d2000: failed to match any schema with compatible: ['brcm,bcm2711-avs-monitor', 'syscon', 'simple-mfd']
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../soc/bcm/brcm,bcm2711-avs-monitor.yaml | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2711-avs-monitor.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2711-avs-monitor.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2711-avs-monitor.yaml
> new file mode 100644
> index 000000000000..e02d9d7e7d9a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2711-avs-monitoryaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/bcm/brcm,bcm2711-avs-monitor.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom AVS Monitor
> +
> +maintainers:
> + - Stefan Wahren <[email protected]>
> +
> +properties:
> + compatible:
> + items:
> + - const: brcm,bcm2711-avs-monitor
> + - const: syscon
> + - const: simple-mfd
> +
> + reg:
> + maxItems: 1
> +
> + thermal:
> + $ref: /schemas/thermal/brcm,avs-ro-thermal.yaml
> + description: Broadcom AVS ring oscillator thermal
> +
> +required:
> + - compatible
> + - reg
> + - thermal
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + avs-monitor@7d5d2000 {
> + compatible = "brcm,bcm2711-avs-monitor", "syscon", "simple-mfd";
> + reg = <0x7d5d2000 0xf00>;
> +
> + thermal: thermal {
> + compatible = "brcm,bcm2711-thermal";
> + #thermal-sensor-cells = <0>;
> + };
> + };
> +...