2024-05-17 17:02:50

by Paolo Bonzini

[permalink] [raw]
Subject: Re: [PATCH 01/20] x86/tdx: Introduce tdvmcall_trampoline()

On 5/17/24 16:19, Kirill A. Shutemov wrote:
> The function will be used from inline assembly to handle most TDVMCALL
> cases.

Perhaps add that the calling convention is designed to allow using the
asm constraints a/b/c/d/S/D and keep the asm blocks simpler?

Paolo



2024-05-20 10:35:57

by Kirill A. Shutemov

[permalink] [raw]
Subject: Re: [PATCH 01/20] x86/tdx: Introduce tdvmcall_trampoline()

On Fri, May 17, 2024 at 07:02:25PM +0200, Paolo Bonzini wrote:
> On 5/17/24 16:19, Kirill A. Shutemov wrote:
> > The function will be used from inline assembly to handle most TDVMCALL
> > cases.
>
> Perhaps add that the calling convention is designed to allow using the asm
> constraints a/b/c/d/S/D and keep the asm blocks simpler?

Sure.

--
Kiryl Shutsemau / Kirill A. Shutemov