2024-05-18 22:55:23

by Jeff Johnson

Subject: [PATCH] kernel: trace: preemptirq_delay_test: add MODULE_DESCRIPTION()

Fix the 'make W=1' warning:

WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/trace/preemptirq_delay_test.o

Signed-off-by: Jeff Johnson <[email protected]>
---
kernel/trace/preemptirq_delay_test.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/trace/preemptirq_delay_test.c b/kernel/trace/preemptirq_delay_test.c
index 8c4ffd076162..cb0871fbdb07 100644
--- a/kernel/trace/preemptirq_delay_test.c
+++ b/kernel/trace/preemptirq_delay_test.c
@@ -215,4 +215,5 @@ static void __exit preemptirq_delay_exit(void)

module_init(preemptirq_delay_init)
module_exit(preemptirq_delay_exit)
+MODULE_DESCRIPTION("Preempt / IRQ disable delay thread to test latency tracers");
MODULE_LICENSE("GPL v2");

---
base-commit: 674143feb6a8c02d899e64e2ba0f992896afd532
change-id: 20240518-md-preemptirq_delay_test-552cd20e7b0b

2024-05-19 02:54:45

by Masami Hiramatsu

Subject: Re: [PATCH] kernel: trace: preemptirq_delay_test: add MODULE_DESCRIPTION()

On Sat, 18 May 2024 15:54:49 -0700
Jeff Johnson <[email protected]> wrote:

> Fix the 'make W=1' warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/trace/preemptirq_delay_test.o
>

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <[email protected]>

Fixes: f96e8577da10 ("lib: Add module for testing preemptoff/irqsoff latency tracers")

Thanks,

> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> kernel/trace/preemptirq_delay_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/preemptirq_delay_test.c b/kernel/trace/preemptirq_delay_test.c
> index 8c4ffd076162..cb0871fbdb07 100644
> --- a/kernel/trace/preemptirq_delay_test.c
> +++ b/kernel/trace/preemptirq_delay_test.c
> @@ -215,4 +215,5 @@ static void __exit preemptirq_delay_exit(void)
>
> module_init(preemptirq_delay_init)
> module_exit(preemptirq_delay_exit)
> +MODULE_DESCRIPTION("Preempt / IRQ disable delay thread to test latency tracers");
> MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: 674143feb6a8c02d899e64e2ba0f992896afd532
> change-id: 20240518-md-preemptirq_delay_test-552cd20e7b0b
>


--
Masami Hiramatsu (Google) <[email protected]>