2024-05-20 10:59:17

by Guido Günther

Subject: [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press

The only key that should wake up the phone is power button press. This
prevents accidental wakeup due to e.g. pressing the buttons in the
pocket or backpack and is in line what userspace uses to unblank the
device.

Signed-off-by: Guido Günther <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index ffb5fe61630d..1b39514d5c12 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -45,7 +45,6 @@ key-vol-down {
gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
linux,code = <KEY_VOLUMEDOWN>;
debounce-interval = <50>;
- wakeup-source;
};

key-vol-up {
@@ -53,7 +52,6 @@ key-vol-up {
gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
linux,code = <KEY_VOLUMEUP>;
debounce-interval = <50>;
- wakeup-source;
};
};

--
2.43.0

2024-06-10 10:55:58

by Martin Kepplinger

Subject: Re: [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press

Am Montag, dem 20.05.2024 um 12:57 +0200 schrieb Guido Günther:
> The only key that should wake up the phone is power button press.
> This
> prevents accidental wakeup due to e.g. pressing the buttons in the
> pocket or backpack and is in line what userspace uses to unblank the
> device.
>
> Signed-off-by: Guido Günther <[email protected]>

Reviewed-by: Martin Kepplinger <[email protected]>

thank you,

martin

> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index ffb5fe61630d..1b39514d5c12 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -45,7 +45,6 @@ key-vol-down {
>                         gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
>                         linux,code = <KEY_VOLUMEDOWN>;
>                         debounce-interval = <50>;
> -                       wakeup-source;
>                 };
>  
>                 key-vol-up {
> @@ -53,7 +52,6 @@ key-vol-up {
>                         gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
>                         linux,code = <KEY_VOLUMEUP>;
>                         debounce-interval = <50>;
> -                       wakeup-source;
>                 };
>         };
>  

2024-06-15 08:29:55

by Shawn Guo

Subject: Re: [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press

On Mon, May 20, 2024 at 12:57:05PM +0200, Guido G?nther wrote:
> The only key that should wake up the phone is power button press. This
> prevents accidental wakeup due to e.g. pressing the buttons in the
> pocket or backpack and is in line what userspace uses to unblank the
> device.
>
> Signed-off-by: Guido G?nther <[email protected]>

'arm64: dts: ...' for subject prefix.

Fixed it up and applied, thanks!

Shawn