2024-05-27 07:14:05

by Yunseong Kim

Subject: [PATCH] tools/virtio: pipe assertion in vring_test.c

From: Yunseong Kim <[email protected]>

The virtio_device need to fail checking when create the geust/host pipe.

Signed-off-by: Yunseong Kim <[email protected]>
---
tools/virtio/vringh_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c
index 98ff808d6f0c..b1af8807c02a 100644
--- a/tools/virtio/vringh_test.c
+++ b/tools/virtio/vringh_test.c
@@ -161,8 +161,8 @@ static int parallel_test(u64 features,
host_map = mmap(NULL, mapsize, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
guest_map = mmap(NULL, mapsize, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);

- pipe(to_guest);
- pipe(to_host);
+ assert(pipe(to_guest) == 0);
+ assert(pipe(to_host) == 0);

CPU_ZERO(&cpu_set);
find_cpus(&first_cpu, &last_cpu);
--
2.34.1

2024-05-27 07:52:55

by Michael S. Tsirkin

Subject: Re: [PATCH] tools/virtio: pipe assertion in vring_test.c

On Mon, May 27, 2024 at 04:13:31PM +0900, [email protected] wrote:
> From: Yunseong Kim <[email protected]>
>
> The virtio_device need to fail checking when create the geust/host pipe.

typo

>
> Signed-off-by: Yunseong Kim <[email protected]>


I guess ...

> ---
> tools/virtio/vringh_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c
> index 98ff808d6f0c..b1af8807c02a 100644
> --- a/tools/virtio/vringh_test.c
> +++ b/tools/virtio/vringh_test.c
> @@ -161,8 +161,8 @@ static int parallel_test(u64 features,
> host_map = mmap(NULL, mapsize, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
> guest_map = mmap(NULL, mapsize, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
>
> - pipe(to_guest);
> - pipe(to_host);
> + assert(pipe(to_guest) == 0);
> + assert(pipe(to_host) == 0);


I don't like == 0, prefer ! .
Also, calling pipe outside assert is preferable, since in theory
assert can be compiled out.
Not an issue here but people tend to copy/paste text.

> CPU_ZERO(&cpu_set);
> find_cpus(&first_cpu, &last_cpu);
> --
> 2.34.1

2024-05-27 08:41:09

by Yunseong Kim

Subject: Re: [PATCH] tools/virtio: pipe assertion in vring_test.c

On 5/27/24 4:52 오후, Michael S. Tsirkin wrote:
> On Mon, May 27, 2024 at 04:13:31PM +0900, [email protected] wrote:
>> From: Yunseong Kim <[email protected]>
>>
>> The virtio_device need to fail checking when create the geust/host pipe.
>
> typo

Thank you for code review Michael.

Sorry, there was a typo in my message.

I'll fix it and send you patch version 2.

>>
>> Signed-off-by: Yunseong Kim <[email protected]>
>
>
> I guess ...
>
>> ---
>> tools/virtio/vringh_test.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c
>> index 98ff808d6f0c..b1af8807c02a 100644
>> --- a/tools/virtio/vringh_test.c
>> +++ b/tools/virtio/vringh_test.c
>> @@ -161,8 +161,8 @@ static int parallel_test(u64 features,
>> host_map = mmap(NULL, mapsize, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
>> guest_map = mmap(NULL, mapsize, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
>>
>> - pipe(to_guest);
>> - pipe(to_host);
>> + assert(pipe(to_guest) == 0);
>> + assert(pipe(to_host) == 0);
>
>
> I don't like == 0, prefer ! .
> Also, calling pipe outside assert is preferable, since in theory
> assert can be compiled out.
> Not an issue here but people tend to copy/paste text.

I agree, it's uncomfortable even if I did it.

I'll fix it as you suggested and send it to patch 2.

Thank you!


Warm Regards,

Yunseong Kim


>> CPU_ZERO(&cpu_set);
>> find_cpus(&first_cpu, &last_cpu);
>> --
>> 2.34.1
>