2024-05-27 16:14:13

by Dr. David Alan Gilbert

Subject: [PATCH] PCI: tegra: remove unused struct 'tegra_pcie_soc'

From: "Dr. David Alan Gilbert" <[email protected]>

'tegra_pcie_soc' has been unused since the initial
commit 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/pci/controller/dwc/pcie-tegra194.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 93f5433c5c55..076f040ccc34 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -308,10 +308,6 @@ static inline u32 appl_readl(struct tegra_pcie_dw *pcie, const u32 reg)
return readl_relaxed(pcie->appl_base + reg);
}

-struct tegra_pcie_soc {
- enum dw_pcie_device_mode mode;
-};
-
static void tegra_pcie_icc_set(struct tegra_pcie_dw *pcie)
{
struct dw_pcie *pci = &pcie->pci;
--
2.45.1

2024-05-28 06:37:21

by Niklas Cassel

Subject: Re: [PATCH] PCI: tegra: remove unused struct 'tegra_pcie_soc'

On Mon, May 27, 2024 at 05:01:18PM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'tegra_pcie_soc' has been unused since the initial
> commit 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 93f5433c5c55..076f040ccc34 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -308,10 +308,6 @@ static inline u32 appl_readl(struct tegra_pcie_dw *pcie, const u32 reg)
> return readl_relaxed(pcie->appl_base + reg);
> }
>
> -struct tegra_pcie_soc {
> - enum dw_pcie_device_mode mode;
> -};
> -
> static void tegra_pcie_icc_set(struct tegra_pcie_dw *pcie)
> {
> struct dw_pcie *pci = &pcie->pci;
> --
> 2.45.1
>

Reviewed-by: Niklas Cassel <[email protected]>

2024-06-06 19:58:52

by Bjorn Helgaas

Subject: Re: [PATCH] PCI: tegra: remove unused struct 'tegra_pcie_soc'

On Mon, May 27, 2024 at 05:01:18PM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'tegra_pcie_soc' has been unused since the initial
> commit 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Applied with Niklas' reviewed-by to pci/controller/tegra194 for v6.11,
thanks!

> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 93f5433c5c55..076f040ccc34 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -308,10 +308,6 @@ static inline u32 appl_readl(struct tegra_pcie_dw *pcie, const u32 reg)
> return readl_relaxed(pcie->appl_base + reg);
> }
>
> -struct tegra_pcie_soc {
> - enum dw_pcie_device_mode mode;
> -};
> -
> static void tegra_pcie_icc_set(struct tegra_pcie_dw *pcie)
> {
> struct dw_pcie *pci = &pcie->pci;
> --
> 2.45.1
>