2024-05-27 18:13:10

by Jeff Johnson

Subject: [PATCH] fs: fat: add missing MODULE_DESCRIPTION() macros

Fix the 'make W=1' warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/fat/fat.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/fat/fat_test.o

Signed-off-by: Jeff Johnson <[email protected]>
---
fs/fat/fat_test.c | 1 +
fs/fat/inode.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/fs/fat/fat_test.c b/fs/fat/fat_test.c
index 2dab4ca1d0d8..1f0062659067 100644
--- a/fs/fat/fat_test.c
+++ b/fs/fat/fat_test.c
@@ -193,4 +193,5 @@ static struct kunit_suite fat_test_suite = {

kunit_test_suites(&fat_test_suite);

+MODULE_DESCRIPTION("KUnit tests for FAT filesystems");
MODULE_LICENSE("GPL v2");
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index d9e6fbb6f246..3027d275dbf1 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1978,4 +1978,5 @@ static void __exit exit_fat_fs(void)
module_init(init_fat_fs)
module_exit(exit_fat_fs)

+MODULE_DESCRIPTION("Core FAT filesystem support");
MODULE_LICENSE("GPL");

---
base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
change-id: 20240527-md-fs-fat-bea9424c9303

2024-05-28 03:46:03

by OGAWA Hirofumi

Subject: Re: [PATCH] fs: fat: add missing MODULE_DESCRIPTION() macros

Jeff Johnson <[email protected]> writes:

> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/fat/fat.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/fat/fat_test.o
>
> Signed-off-by: Jeff Johnson <[email protected]>

Looks good.

Acked-by: OGAWA Hirofumi <[email protected]>

Thanks.

> ---
> fs/fat/fat_test.c | 1 +
> fs/fat/inode.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/fs/fat/fat_test.c b/fs/fat/fat_test.c
> index 2dab4ca1d0d8..1f0062659067 100644
> --- a/fs/fat/fat_test.c
> +++ b/fs/fat/fat_test.c
> @@ -193,4 +193,5 @@ static struct kunit_suite fat_test_suite = {
>
> kunit_test_suites(&fat_test_suite);
>
> +MODULE_DESCRIPTION("KUnit tests for FAT filesystems");
> MODULE_LICENSE("GPL v2");
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index d9e6fbb6f246..3027d275dbf1 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1978,4 +1978,5 @@ static void __exit exit_fat_fs(void)
> module_init(init_fat_fs)
> module_exit(exit_fat_fs)
>
> +MODULE_DESCRIPTION("Core FAT filesystem support");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
> change-id: 20240527-md-fs-fat-bea9424c9303
>

--
OGAWA Hirofumi <[email protected]>

2024-05-28 11:35:19

by Christian Brauner

Subject: Re: [PATCH] fs: fat: add missing MODULE_DESCRIPTION() macros

On Mon, 27 May 2024 11:00:40 -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/fat/fat.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/fat/fat_test.o
>
>

Applied to the v6.10-rc1 branch of the vfs/vfs.git tree.
Patches in the v6.10-rc1 branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: v6.10-rc1

[1/1] fs: fat: add missing MODULE_DESCRIPTION() macros
https://git.kernel.org/vfs/vfs/c/9101026fc35c