2024-05-28 00:06:49

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH 0/2] power: dead struct removal

From: "Dr. David Alan Gilbert" <[email protected]>

A couple of dead struct removals in drivers/power

Build tested.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Dr. David Alan Gilbert (2):
power: supply: bd99954: remove unused struct 'battery_data'
power: supply: ab8500: remove unused struct 'inst_curr_result_list'

drivers/power/supply/ab8500_fg.c | 5 -----
drivers/power/supply/bd99954-charger.c | 7 -------
2 files changed, 12 deletions(-)

--
2.45.1



2024-05-28 00:07:02

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH 1/2] power: supply: bd99954: remove unused struct 'battery_data'

From: "Dr. David Alan Gilbert" <[email protected]>

'battery_data' is unused since the original
commit 0902f8366491 ("power: supply: Support ROHM bd99954 charger").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/power/supply/bd99954-charger.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/power/supply/bd99954-charger.c b/drivers/power/supply/bd99954-charger.c
index 1ed1d9f99fb3..54bf88262510 100644
--- a/drivers/power/supply/bd99954-charger.c
+++ b/drivers/power/supply/bd99954-charger.c
@@ -70,13 +70,6 @@

#include "bd99954-charger.h"

-struct battery_data {
- u16 precharge_current; /* Trickle-charge Current */
- u16 fc_reg_voltage; /* Fast Charging Regulation Voltage */
- u16 voltage_min;
- u16 voltage_max;
-};
-
/* Initial field values, converted to initial register values */
struct bd9995x_init_data {
u16 vsysreg_set; /* VSYS Regulation Setting */
--
2.45.1


2024-05-28 00:07:14

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH 2/2] power: supply: ab8500: remove unused struct 'inst_curr_result_list'

From: "Dr. David Alan Gilbert" <[email protected]>

'inst_curr_result_list' is unused since the original
commit 13151631b5bd ("ab8500-fg: A8500 fuel gauge driver").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/power/supply/ab8500_fg.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c
index 2ccaf6116c09..270874eeb934 100644
--- a/drivers/power/supply/ab8500_fg.c
+++ b/drivers/power/supply/ab8500_fg.c
@@ -149,11 +149,6 @@ struct ab8500_fg_flags {
bool batt_id_received;
};

-struct inst_curr_result_list {
- struct list_head list;
- int *result;
-};
-
/**
* struct ab8500_fg - ab8500 FG device information
* @dev: Pointer to the structure device
--
2.45.1


2024-05-28 05:37:24

by Matti Vaittinen

[permalink] [raw]
Subject: Re: [PATCH 1/2] power: supply: bd99954: remove unused struct 'battery_data'

On 5/28/24 03:06, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'battery_data' is unused since the original
> commit 0902f8366491 ("power: supply: Support ROHM bd99954 charger").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Acked-by: Matti Vaittinen <[email protected]>

Thanks!

> ---
> drivers/power/supply/bd99954-charger.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/power/supply/bd99954-charger.c b/drivers/power/supply/bd99954-charger.c
> index 1ed1d9f99fb3..54bf88262510 100644
> --- a/drivers/power/supply/bd99954-charger.c
> +++ b/drivers/power/supply/bd99954-charger.c
> @@ -70,13 +70,6 @@
>
> #include "bd99954-charger.h"
>
> -struct battery_data {
> - u16 precharge_current; /* Trickle-charge Current */
> - u16 fc_reg_voltage; /* Fast Charging Regulation Voltage */
> - u16 voltage_min;
> - u16 voltage_max;
> -};
> -
> /* Initial field values, converted to initial register values */
> struct bd9995x_init_data {
> u16 vsysreg_set; /* VSYS Regulation Setting */

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~


2024-05-29 07:48:52

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 2/2] power: supply: ab8500: remove unused struct 'inst_curr_result_list'

On Tue, May 28, 2024 at 2:06 AM <[email protected]> wrote:

> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'inst_curr_result_list' is unused since the original
> commit 13151631b5bd ("ab8500-fg: A8500 fuel gauge driver").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij