2024-05-28 19:17:44

by Rob Herring (Arm)

Subject: [PATCH] arm: dts: realview: Add/drop missing/spurious unit-addreses

Various nodes on the Arm Realview boards have missing or spurious
unit-addresses.

Signed-off-by: Rob Herring (Arm) <[email protected]>
---
arch/arm/boot/dts/arm/arm-realview-eb-mp.dtsi | 2 +-
arch/arm/boot/dts/arm/arm-realview-pb11mp.dts | 2 +-
arch/arm/boot/dts/arm/arm-realview-pba8.dts | 2 +-
arch/arm/boot/dts/arm/arm-realview-pbx-a9.dts | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/arm/arm-realview-eb-mp.dtsi b/arch/arm/boot/dts/arm/arm-realview-eb-mp.dtsi
index 26783d053ac7..40f7515aa068 100644
--- a/arch/arm/boot/dts/arm/arm-realview-eb-mp.dtsi
+++ b/arch/arm/boot/dts/arm/arm-realview-eb-mp.dtsi
@@ -103,7 +103,7 @@ twd_wdog: watchdog@1f000620 {
};

/* PMU with one IRQ line per core */
- pmu: pmu@0 {
+ pmu: pmu {
compatible = "arm,arm11mpcore-pmu";
interrupt-parent = <&intc>;
interrupts = <0 17 IRQ_TYPE_LEVEL_HIGH>,
diff --git a/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts b/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts
index 14ce47d42e3d..29afc5c05759 100644
--- a/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts
+++ b/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts
@@ -92,7 +92,7 @@ intc_tc11mp: interrupt-controller@1f000100 {
<0x1f000100 0x100>;
};

- L2: cache-controller {
+ L2: cache-controller@1f002000 {
compatible = "arm,l220-cache";
reg = <0x1f002000 0x1000>;
interrupt-parent = <&intc_tc11mp>;
diff --git a/arch/arm/boot/dts/arm/arm-realview-pba8.dts b/arch/arm/boot/dts/arm/arm-realview-pba8.dts
index d3238c252b59..d2e0082245f9 100644
--- a/arch/arm/boot/dts/arm/arm-realview-pba8.dts
+++ b/arch/arm/boot/dts/arm/arm-realview-pba8.dts
@@ -40,7 +40,7 @@ cpu0: cpu@0 {
};
};

- pmu: pmu@0 {
+ pmu: pmu {
compatible = "arm,cortex-a8-pmu";
interrupt-parent = <&intc>;
interrupts = <0 47 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/arch/arm/boot/dts/arm/arm-realview-pbx-a9.dts b/arch/arm/boot/dts/arm/arm-realview-pbx-a9.dts
index 85d3968fbb91..507ad7ac4974 100644
--- a/arch/arm/boot/dts/arm/arm-realview-pbx-a9.dts
+++ b/arch/arm/boot/dts/arm/arm-realview-pbx-a9.dts
@@ -97,7 +97,7 @@ twd_wdog: watchdog@1f000620 {
interrupts = <1 14 0xf04>;
};

- pmu: pmu@0 {
+ pmu: pmu {
compatible = "arm,cortex-a9-pmu";
interrupt-parent = <&intc>;
interrupts = <0 44 IRQ_TYPE_LEVEL_HIGH>,
--
2.43.0

2024-05-29 08:51:07

by Linus Walleij

Subject: Re: [PATCH] arm: dts: realview: Add/drop missing/spurious unit-addreses

On Tue, May 28, 2024 at 9:15 PM Rob Herring (Arm) <[email protected]> wrote:

> Various nodes on the Arm Realview boards have missing or spurious
> unit-addresses.
>
> Signed-off-by: Rob Herring (Arm) <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

I send pull requests for these files very seldom and the risk of
collision is practically zero, could you take the patch through your
DT tree?

Yours,
Linus Walleij