2024-05-29 05:14:16

by Andrew Jeffery

[permalink] [raw]
Subject: [PATCH 2/4] dt-bindings: gpio: aspeed,sgpio: Specify gpio-line-names

Some devicetrees specify gpio-line-names in the sgpio node despite it
not being defined by the binding. It's a reasonable thing to do, so
define the property to squash warnings such as:

```
arch/arm/boot/dts/aspeed/aspeed-bmc-vegman-rx20.dtb: sgpio@1e780200: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+'
```

Signed-off-by: Andrew Jeffery <[email protected]>
---
Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
index 6b15a3a3fb66..fe27b5d01e80 100644
--- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
@@ -33,6 +33,11 @@ properties:

gpio-controller: true

+ # Each SGPIO is represented as a pair of input and output GPIOs
+ gpio-line-names:
+ minItems: 160
+ maxItems: 256
+
'#gpio-cells':
const: 2


--
2.39.2



2024-05-29 07:38:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/4] dt-bindings: gpio: aspeed,sgpio: Specify gpio-line-names

On 29/05/2024 07:13, Andrew Jeffery wrote:
> Some devicetrees specify gpio-line-names in the sgpio node despite it
> not being defined by the binding. It's a reasonable thing to do, so
> define the property to squash warnings such as:
>
> ```

No need for ```

This is just commit log. Not markdown.


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof


2024-05-30 00:51:30

by Andrew Jeffery

[permalink] [raw]
Subject: Re: [PATCH 2/4] dt-bindings: gpio: aspeed,sgpio: Specify gpio-line-names

On Wed, 2024-05-29 at 09:27 +0200, Krzysztof Kozlowski wrote:
> On 29/05/2024 07:13, Andrew Jeffery wrote:
> > Some devicetrees specify gpio-line-names in the sgpio node despite it
> > not being defined by the binding. It's a reasonable thing to do, so
> > define the property to squash warnings such as:
> >
> > ```
>
> No need for ```
>
> This is just commit log. Not markdown.

I'm going to do a v2 anyway, so I'll drop the markup.

> Acked-by: Krzysztof Kozlowski <[email protected]>

Thanks,

Andrew