2024-05-29 21:26:05

by Jeff Johnson

Subject: [PATCH] kernel/sysctl-test: add MODULE_DESCRIPTION()

Fix the 'make W=1' warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/sysctl-test.o

Signed-off-by: Jeff Johnson <[email protected]>
---
kernel/sysctl-test.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/sysctl-test.c b/kernel/sysctl-test.c
index 6ef887c19c48..92f94ea28957 100644
--- a/kernel/sysctl-test.c
+++ b/kernel/sysctl-test.c
@@ -388,4 +388,5 @@ static struct kunit_suite sysctl_test_suite = {

kunit_test_suites(&sysctl_test_suite);

+MODULE_DESCRIPTION("KUnit test of proc sysctl");
MODULE_LICENSE("GPL v2");

---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240529-md-kernel-sysctl-test-2bbad793ac62

2024-06-04 06:08:39

by Joel Granados

Subject: Re: [PATCH] kernel/sysctl-test: add MODULE_DESCRIPTION()

On Wed, May 29, 2024 at 02:25:41PM -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/sysctl-test.o
>
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> kernel/sysctl-test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/sysctl-test.c b/kernel/sysctl-test.c
> index 6ef887c19c48..92f94ea28957 100644
> --- a/kernel/sysctl-test.c
> +++ b/kernel/sysctl-test.c
> @@ -388,4 +388,5 @@ static struct kunit_suite sysctl_test_suite = {
>
> kunit_test_suites(&sysctl_test_suite);
>
> +MODULE_DESCRIPTION("KUnit test of proc sysctl");

thx
Reviewed-by: Joel Granados <[email protected]>

> MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240529-md-kernel-sysctl-test-2bbad793ac62
>


--

Joel Granados

2024-06-04 06:11:29

by Joel Granados

Subject: Re: [PATCH] kernel/sysctl-test: add MODULE_DESCRIPTION()

On Wed, May 29, 2024 at 02:25:41PM -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/sysctl-test.o

I changed the message to this
"""
sysctl: Add module description to sysctl-testing

Added a module description to sysctl Kunit self test module to fix the
'make W=1' warning (" WARNING: modpost: missing MODULE_DESCRIPTION() in
kernel/sysctl-test.o")
"""

>
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> kernel/sysctl-test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/sysctl-test.c b/kernel/sysctl-test.c
> index 6ef887c19c48..92f94ea28957 100644
> --- a/kernel/sysctl-test.c
> +++ b/kernel/sysctl-test.c
> @@ -388,4 +388,5 @@ static struct kunit_suite sysctl_test_suite = {
>
> kunit_test_suites(&sysctl_test_suite);
>
> +MODULE_DESCRIPTION("KUnit test of proc sysctl");
> MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240529-md-kernel-sysctl-test-2bbad793ac62
>

--

Joel Granados