2024-05-30 14:24:06

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] selftests/futex: clang-inspired fixes

On 5/28/24 20:29, John Hubbard wrote:
> Hi,
>
> Here's a few fixes that are part of my effort to get all selftests
> building cleanly under clang. Plus one that I noticed by inspection.
>
> Changes since the first version:
>
> 1) Rebased onto Linux 6.10-rc1
> 2) Added Reviewed-by's.
>
> ...and it turns out that all three patches are still required, on -rc1,
> in order to get a clean clang build.

Thank you. I will apply these for the next rc.

thanks,
-- Shuah


2024-05-30 19:10:06

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] selftests/futex: clang-inspired fixes

On 5/30/24 08:23, Shuah Khan wrote:
> On 5/28/24 20:29, John Hubbard wrote:
>> Hi,
>>
>> Here's a few fixes that are part of my effort to get all selftests
>> building cleanly under clang. Plus one that I noticed by inspection.
>>
>> Changes since the first version:
>>
>> 1) Rebased onto Linux 6.10-rc1
>> 2) Added Reviewed-by's.
>>
>> ...and it turns out that all three patches are still required, on -rc1,
>> in order to get a clean clang build.
>
> Thank you. I will apply these for the next rc.


John Hubbard (3):
selftests/futex: don't redefine .PHONY targets (all, clean)
selftests/futex: don't pass a const char* to asprintf(3)

Patch 1/3 and 2/3 please see changes requested.

Applied to linux-kselftest fixes branch
selftests/futex: pass _GNU_SOURCE without a value to the compiler

thanks,
-- Shuah