2024-06-02 00:25:39

by Jeff Johnson

[permalink] [raw]
Subject: [PATCH] fprobe: add missing MODULE_DESCRIPTION() macro

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in samples/fprobe/fprobe_example.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <[email protected]>
---
samples/fprobe/fprobe_example.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/samples/fprobe/fprobe_example.c b/samples/fprobe/fprobe_example.c
index 64e715e7ed11..0a50b05add96 100644
--- a/samples/fprobe/fprobe_example.c
+++ b/samples/fprobe/fprobe_example.c
@@ -150,4 +150,5 @@ static void __exit fprobe_exit(void)

module_init(fprobe_init)
module_exit(fprobe_exit)
+MODULE_DESCRIPTION("sample kernel module showing the use of fprobe");
MODULE_LICENSE("GPL");

---
base-commit: b050496579632f86ee1ef7e7501906db579f3457
change-id: 20240601-md-samples-fprobe-b2b92d8be350



2024-06-02 01:07:07

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH] fprobe: add missing MODULE_DESCRIPTION() macro

On Sat, 1 Jun 2024 17:25:22 -0700
Jeff Johnson <[email protected]> wrote:

> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/fprobe/fprobe_example.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>

Thanks for adding this. Looks good to me.

Let me pick it to probes/for-next.


> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> samples/fprobe/fprobe_example.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/samples/fprobe/fprobe_example.c b/samples/fprobe/fprobe_example.c
> index 64e715e7ed11..0a50b05add96 100644
> --- a/samples/fprobe/fprobe_example.c
> +++ b/samples/fprobe/fprobe_example.c
> @@ -150,4 +150,5 @@ static void __exit fprobe_exit(void)
>
> module_init(fprobe_init)
> module_exit(fprobe_exit)
> +MODULE_DESCRIPTION("sample kernel module showing the use of fprobe");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> change-id: 20240601-md-samples-fprobe-b2b92d8be350
>


--
Masami Hiramatsu (Google) <[email protected]>