2024-06-03 01:47:25

by Qianbin Zheng (NSB)

Subject: [PATCH] usb: gadget: fsl: Enable usb snoop on PPC64

Turn on usb snooping on PPC64.

Signed-off-by: Qianbin Zheng <[email protected]>
---
drivers/usb/gadget/udc/fsl_udc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
index 3432ebfae978..a0f3498086d5 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -328,7 +328,7 @@ static int dr_controller_setup(struct fsl_udc *udc)
__raw_writel(ctrl, &usb_sys_regs->control);
}

-#if defined(CONFIG_PPC32) && !defined(CONFIG_NOT_COHERENT_CACHE)
+#if (defined(CONFIG_PPC32) || (defined(CONFIG_PPC64))) && !defined(CONFIG_NOT_COHERENT_CACHE)
/* Turn on cache snooping hardware, since some PowerPC platforms
* wholly rely on hardware to deal with cache coherent. */

--
2.31.1

2024-06-03 06:43:22

by Greg Kroah-Hartman

Subject: Re: [PATCH] usb: gadget: fsl: Enable usb snoop on PPC64

On Mon, Jun 03, 2024 at 01:46:50AM +0000, Qianbin Zheng (NSB) wrote:
> Turn on usb snooping on PPC64.

This says what you are doing, but not _why_ you are doing it?

What changed to allow this to now work properly?

thanks,

greg k-h