2024-06-09 20:37:07

by Danila Tikhonov

Subject: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08

The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode
AMOLED panel used in:
- Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis)
- Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci)
- Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael)
Add a dt-binding for it.

Signed-off-by: Danila Tikhonov <[email protected]>
---
.../display/panel/samsung,ams639rq08.yaml | 80 +++++++++++++++++++
1 file changed, 80 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,ams639rq08.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/samsung,ams639rq08.yaml b/Documentation/devicetree/bindings/display/panel/samsung,ams639rq08.yaml
new file mode 100644
index 0000000000000..3a561156f5601
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,ams639rq08.yaml
@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/samsung,ams639rq08.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung AMS639RQ08 EA8076-based 6.39" 1080x2340 MIPI-DSI Panel
+
+maintainers:
+ - Danila Tikhonov <[email protected]>
+ - Jens Reidel <[email protected]>
+
+description: |
+ The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode AMOLED panel.
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ const: samsung,ams639rq08
+
+ reg:
+ maxItems: 1
+
+ vdd3p3-supply:
+ description: 3.3V source voltage rail
+
+ vddio-supply:
+ description: I/O source voltage rail
+
+ vsn-supply:
+ description: Positive source voltage rail
+
+ vsp-supply:
+ description: Negative source voltage rail
+
+ reset-gpios: true
+ port: true
+
+additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - vdd3p3-supply
+ - vddio-supply
+ - vsn-supply
+ - vsp-supply
+ - reset-gpios
+ - port
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "samsung,ams639rq08";
+ reg = <0>;
+
+ vdd3p3-supply = <&vreg_l18a_2p8>;
+ vddio-supply = <&vreg_l13a_1p8>;
+ vsn-supply = <&vreg_ibb>;
+ vsp-supply = <&vreg_lab>;
+
+ reset-gpios = <&pm6150l_gpios 9 GPIO_ACTIVE_LOW>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+ };
+
+...
--
2.45.2

2024-06-10 08:20:56

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08

On 09/06/2024 22:36, Danila Tikhonov wrote:
> The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode
> AMOLED panel used in:
> - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis)
> - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci)
> - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael)
> Add a dt-binding for it.
>
> Signed-off-by: Danila Tikhonov <[email protected]>

If there is going to be any new posting, then two changes:


> +maintainers:
> + - Danila Tikhonov <[email protected]>
> + - Jens Reidel <[email protected]>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> + The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode AMOLED panel.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: samsung,ams639rq08
> +
> + reg:
> + maxItems: 1
> +
> + vdd3p3-supply:
> + description: 3.3V source voltage rail
> +
> + vddio-supply:
> + description: I/O source voltage rail
> +
> + vsn-supply:
> + description: Positive source voltage rail
> +
> + vsp-supply:
> + description: Negative source voltage rail
> +
> + reset-gpios: true
> + port: true
> +
> +additionalProperties: false

This goes after "required:" block.

> +
> +required:
> + - compatible
> + - reg
> + - vdd3p3-supply
> + - vddio-supply
> + - vsn-supply
> + - vsp-supply
> + - reset-gpios
> + - port
> +

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof