2024-06-14 09:04:50

by John Garry

Subject: [PATCH 1/3] bdev: make blockdev_mnt static

From: Jiapeng Chong <[email protected]>

The blockdev_mnt are not used outside the file bdev.c, so the modification
is defined as static.

block/bdev.c:377:17: warning: symbol 'blockdev_mnt' was not declared. Should it be static?

Reported-by: Abaci Robot <[email protected]>
jpg: Remove closes bugzilla link
Reviewed-by: Christoph Hellwig <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
Signed-off-by: John Garry <[email protected]>
---
block/bdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/bdev.c b/block/bdev.c
index 353677ac49b3..ced4ac990ec8 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -385,7 +385,7 @@ static struct file_system_type bd_type = {
};

struct super_block *blockdev_superblock __ro_after_init;
-struct vfsmount *blockdev_mnt __ro_after_init;
+static struct vfsmount *blockdev_mnt __ro_after_init;
EXPORT_SYMBOL_GPL(blockdev_superblock);

void __init bdev_cache_init(void)
--
2.31.1

2024-06-14 16:40:12

by Bart Van Assche

Subject: Re: [PATCH 1/3] bdev: make blockdev_mnt static

On 6/14/24 2:03 AM, John Garry wrote:
> The blockdev_mnt are not used outside the file bdev.c, so the modification
> is defined as static.

If this patch would be reposted, please rewrite the above description such that
it becomes comprehensible.

> jpg: Remove closes bugzilla link

The above text should be surrounded with square brackets.

Anyway:

Reviewed-by: Bart Van Assche <[email protected]>