2024-06-15 10:05:53

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings

On 14/06/2024 16:56, Zhaoxiong Lv wrote:
> This add the bindings for the 1280x800 TFT LCD Starry-er88577 DSI panel

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18


> to panel-simple-dsi.
>
> Signed-off-by: Zhaoxiong Lv <[email protected]>
> ---


> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index db5acd2807ed..1f04acefba4e 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -60,6 +60,8 @@ properties:
> - samsung,sofef00
> # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT LCD panel
> - tdo,tl070wsh30
> + # The Starry-er88577 is a 10.1" WXGA TFT-LCD panel
> + - starry,er88577

Don't add to the end of lists, but keep proper alphabetical order.

Best regards,
Krzysztof