2024-06-15 10:06:25

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 2/4] dt-bindings: display: panel: Add compatible for kingdisplay-kd101ne3

On 14/06/2024 16:55, Zhaoxiong Lv wrote:
> The kingdisplay-kd101ne3 is a 10.1" WXGA TFT-LCD panel with
> jadard-jd9365da controller. Hence, we add a new compatible
> with panel specific config.
>
> Signed-off-by: Zhaoxiong Lv <[email protected]>
> ---
> Chage since V3:
>
> - 1. Abandon the V2 patch and add kingdisplay kd101ne3-40ti binding to
> - jadard,jd9365da-h3.yaml again.
>
> V2:https://lore.kernel.org/all/20240601084528.22502-2-lvzhaoxiong@huaqin.corp-partner.google.com/
>
> Chage since V2:
>
> - Drop some properties that have already been defined in panel-common.
> - The header file 'dt-bindings/gpio/gpio.h' is not used, delete it
>
> V1: https://lore.kernel.org/all/20240418081548.12160-2-lvzhaoxiong@huaqin.corp-partner.google.com/
>
> ---
> .../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> index 41eb7fbf7715..6138d853a15b 100644
> --- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> @@ -19,6 +19,7 @@ properties:
> - chongzhou,cz101b4001
> - radxa,display-10hd-ad001
> - radxa,display-8hd-ad002
> + - kingdisplay,kd101ne3-40ti

Again, don't add to the end of the lists. Look - list is ordered.


Best regards,
Krzysztof