2008-02-08 22:42:36

by Adrian Bunk

Subject: uml compile error

Commit dd2cc4dff3b08ab54c4c177a080046bcc84ac41d broke uml:

<-- snip -->

...
CC fs/hostfs/hostfs_kern.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c: In function ‘hostfs_show_options’:
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c:328: error: dereferencing pointer to incomplete type
make[3]: *** [fs/hostfs/hostfs_kern.o] Error 1

<-- snip -->

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2008-02-09 00:06:41

by Jiri Kosina

Subject: Re: uml compile error

On Sat, 9 Feb 2008, Adrian Bunk wrote:

> Commit dd2cc4dff3b08ab54c4c177a080046bcc84ac41d broke uml:
> <-- snip -->
> ...
> CC fs/hostfs/hostfs_kern.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c: In function 'hostfs_show_options':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c:328: error: dereferencing pointer to incomplete type
> make[3]: *** [fs/hostfs/hostfs_kern.o] Error 1

I guess we need this one?



From: Jiri Kosina <[email protected]>

UML: fix hostfs build

We need to include mount.h to get vfsmount.

Signed-off-by: Jiri Kosina <[email protected]>

diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index d0549cb..5222345 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -12,6 +12,7 @@
#include <linux/pagemap.h>
#include <linux/statfs.h>
#include <linux/seq_file.h>
+#include <linux/mount.h>
#include "hostfs.h"
#include "init.h"
#include "kern.h"

2008-02-09 00:25:28

by Adrian Bunk

Subject: Re: uml compile error

On Sat, Feb 09, 2008 at 01:05:15AM +0100, Jiri Kosina wrote:
> On Sat, 9 Feb 2008, Adrian Bunk wrote:
>
> > Commit dd2cc4dff3b08ab54c4c177a080046bcc84ac41d broke uml:
> > <-- snip -->
> > ...
> > CC fs/hostfs/hostfs_kern.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c: In function 'hostfs_show_options':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c:328: error: dereferencing pointer to incomplete type
> > make[3]: *** [fs/hostfs/hostfs_kern.o] Error 1
>
> I guess we need this one?
>
>
>
> From: Jiri Kosina <[email protected]>
>
> UML: fix hostfs build
>...

Thanks that fixed it.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2008-02-13 22:26:27

by Rafael J. Wysocki

Subject: Re: uml compile error

On Friday, 8 of February 2008, Adrian Bunk wrote:
> Commit dd2cc4dff3b08ab54c4c177a080046bcc84ac41d broke uml:
>
> <-- snip -->
>
> ...
> CC fs/hostfs/hostfs_kern.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c: In function ‘hostfs_show_options’:
> /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c:328: error: dereferencing pointer to incomplete type
> make[3]: *** [fs/hostfs/hostfs_kern.o] Error 1
>
> <-- snip -->

Has it been fixed in the mainline?

Rafael

2008-02-13 22:28:50

by Adrian Bunk

Subject: Re: uml compile error

On Wed, Feb 13, 2008 at 11:24:31PM +0100, Rafael J. Wysocki wrote:
> On Friday, 8 of February 2008, Adrian Bunk wrote:
> > Commit dd2cc4dff3b08ab54c4c177a080046bcc84ac41d broke uml:
> >
> > <-- snip -->
> >
> > ...
> > CC fs/hostfs/hostfs_kern.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c: In function ‘hostfs_show_options’:
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c:328: error: dereferencing pointer to incomplete type
> > make[3]: *** [fs/hostfs/hostfs_kern.o] Error 1
> >
> > <-- snip -->
>
> Has it been fixed in the mainline?

Yes.

> Rafael

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed