2008-02-14 21:24:33

by Adrian Bunk

Subject: [2.6 patch] make marker_debug static

With the needlessly global marker_debug being static gcc can optimize
the unused code away.

Signed-off-by: Adrian Bunk <[email protected]>

---
91577cc8ac60bf9003d0dd037a231db363003740 diff --git a/kernel/marker.c b/kernel/marker.c
index c4c2cd8..133bdbb 100644
--- a/kernel/marker.c
+++ b/kernel/marker.c
@@ -28,7 +28,7 @@ extern struct marker __start___markers[];
extern struct marker __stop___markers[];

/* Set to 1 to enable marker debug output */
-const int marker_debug;
+static const int marker_debug;

/*
* markers_mutex nests inside module_mutex. Markers mutex protects the builtin

2008-02-14 22:37:41

by Mathieu Desnoyers

Subject: Re: [2.6 patch] make marker_debug static

* Adrian Bunk ([email protected]) wrote:
> With the needlessly global marker_debug being static gcc can optimize
> the unused code away.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>

Thanks,

Acked-by: Mathieu Desnoyers <[email protected]>

> ---
> 91577cc8ac60bf9003d0dd037a231db363003740 diff --git a/kernel/marker.c b/kernel/marker.c
> index c4c2cd8..133bdbb 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -28,7 +28,7 @@ extern struct marker __start___markers[];
> extern struct marker __stop___markers[];
>
> /* Set to 1 to enable marker debug output */
> -const int marker_debug;
> +static const int marker_debug;
>
> /*
> * markers_mutex nests inside module_mutex. Markers mutex protects the builtin
>

--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68