2000-11-23 03:10:48

by Adam J. Richter

[permalink] [raw]
Subject: Patch(?): linux-2.4.0-test11/drivers/char pci_device_id tables

The following patch adds a pci_device_id table and a
MODULE_DEVICE_TABLE delcaration to each remaining PCI driver
in linux-2.4.0-test11/drivers/char/. I have used the named initializer
format for drivers that have only one or two PCI entries, initialize from
anonymous integers or where the unlabelled format would still
result in more than one line per entry in spite of any spacing

I believe I have now posted patches that completes pci_device_id
table coverage for the following directories:


Here is a summary of the number of files in other kernel
directories remaining to be updated (generated by counting the number
of files with "pci_find" and without "MODULE_DEVICE_TABLE" and removing
some obviously inapplicable cases):

drivers/acpi 1
drivers/atm 6
drivers/ide 5
drivers/ieee1394 3
drivers/isdn/avmb1 3
drivers/isdn/eicon 2
drivers/isdn/hisax 13
drivers/isdn/hysdn 1
drivers/media/radio 1
drivers/media/video 4
drivers/mtd 1
drivers/net/tokenring 1
drivers/pcmcia 1
drivers/sbus/char 1
drivers/telephony 1
drivers/video 7

As you can see, we are converging on complete MODULE_DEVICE_TABLE
coverage for all PCI drivers.

Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
[email protected] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."

(No filename) (1.55 kB)
char.diffs (13.04 kB)
Download all attachments

2000-11-23 09:22:58

by Peter Samuelson

[permalink] [raw]
Subject: Re: Patch(?): linux-2.4.0-test11/drivers/char pci_device_id tables

[Adam J. Richter]
> +static struct pci_device_id isicom_pci_tbl[] __initdata = {
> + { VENDOR_ID, 0x2028, PCI_ANY_ID, PCI_ANY_ID },
> + { VENDOR_ID, 0x2051, PCI_ANY_ID, PCI_ANY_ID },
> + { VENDOR_ID, 0x2052, PCI_ANY_ID, PCI_ANY_ID },
> + { VENDOR_ID, 0x2053, PCI_ANY_ID, PCI_ANY_ID },
> + { VENDOR_ID, 0x2054, PCI_ANY_ID, PCI_ANY_ID },
> + { VENDOR_ID, 0x2055, PCI_ANY_ID, PCI_ANY_ID },
> + { VENDOR_ID, 0x2056, PCI_ANY_ID, PCI_ANY_ID },
> + { VENDOR_ID, 0x2057, PCI_ANY_ID, PCI_ANY_ID },
> + { VENDOR_ID, 0x2058, PCI_ANY_ID, PCI_ANY_ID },

Eh. Once again the numbers are ugly. Unfortunately the ISICom
situation is non-obvious. Multi-Tech is using the same PCI ID (10b5)
as PLX, even though according to pci.ids they have their own (1122).
Furthermore, the driver source does not indicate which of the five
supported models is which. Oh well, maybe this one *isn't* worth
trying to clean up..