2008-02-22 19:59:42

by Adrian Bunk

Subject: [2.6 patch] make smackfs.c:smk_unlbl_ambient() static

This patch makes the needlessly global smk_unlbl_ambient() static.

Signed-off-by: Adrian Bunk <[email protected]>

---
60c7072cb922cdecdb8a4f08e5710c014e0e8a8c diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 358c92c..7c6e671 100644
--- a/security/smack/smackfs.c
+++ b/security/smack/smackfs.c
@@ -371,7 +371,7 @@ void smk_cipso_doi(void)
/**
* smk_unlbl_ambient - initialize the unlabeled domain
*/
-void smk_unlbl_ambient(char *oldambient)
+static void smk_unlbl_ambient(char *oldambient)
{
int rc;
struct netlbl_audit audit_info;

2008-02-22 20:08:01

by Paul Moore

Subject: Re: [2.6 patch] make smackfs.c:smk_unlbl_ambient() static

On Friday 22 February 2008 2:58:07 pm Adrian Bunk wrote:
> This patch makes the needlessly global smk_unlbl_ambient() static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Fine with me.

Acked-by: Paul Moore <[email protected]>

> ---
> 60c7072cb922cdecdb8a4f08e5710c014e0e8a8c diff --git
> a/security/smack/smackfs.c b/security/smack/smackfs.c index
> 358c92c..7c6e671 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -371,7 +371,7 @@ void smk_cipso_doi(void)
> /**
> * smk_unlbl_ambient - initialize the unlabeled domain
> */
> -void smk_unlbl_ambient(char *oldambient)
> +static void smk_unlbl_ambient(char *oldambient)
> {
> int rc;
> struct netlbl_audit audit_info;



--
paul moore
linux security @ hp

2008-02-23 01:09:47

by Casey Schaufler

Subject: Re: [2.6 patch] make smackfs.c:smk_unlbl_ambient() static

--- Adrian Bunk <[email protected]> wrote:

> This patch makes the needlessly global smk_unlbl_ambient() static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Casey Schaufler <[email protected]>

Oops.

>
> ---
> 60c7072cb922cdecdb8a4f08e5710c014e0e8a8c diff --git
> a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 358c92c..7c6e671 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -371,7 +371,7 @@ void smk_cipso_doi(void)
> /**
> * smk_unlbl_ambient - initialize the unlabeled domain
> */
> -void smk_unlbl_ambient(char *oldambient)
> +static void smk_unlbl_ambient(char *oldambient)
> {
> int rc;
> struct netlbl_audit audit_info;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
>


Casey Schaufler
[email protected]

2008-02-24 18:55:44

by Casey Schaufler

Subject: Re: [2.6 patch] make smackfs.c:smk_unlbl_ambient() static

--- Adrian Bunk <[email protected]> wrote:

> This patch makes the needlessly global smk_unlbl_ambient() static.
>
> Signed-off-by: Adrian Bunk <[email protected]>
Acked-by: Casey Schaufler <[email protected]>

>
> ---
> 60c7072cb922cdecdb8a4f08e5710c014e0e8a8c diff --git
> a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 358c92c..7c6e671 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -371,7 +371,7 @@ void smk_cipso_doi(void)
> /**
> * smk_unlbl_ambient - initialize the unlabeled domain
> */
> -void smk_unlbl_ambient(char *oldambient)
> +static void smk_unlbl_ambient(char *oldambient)
> {
> int rc;
> struct netlbl_audit audit_info;
>
>
>


Casey Schaufler
[email protected]