2002-01-09 19:36:03

by Pozsar Balazs

Subject: [PATCH] 8139too: too early dev_kfree_skb

This patch was originally sent to lkml on nov 30, 2001, from
<[email protected]>, but it is not in 2.4.18-pre2.

Was it just overlooked, or is it unneccessary?

Note that I rediffed it, and moved the +dev_kfree_skb after the DPRINTK,
because it also uses the len.

patch follows:

--- linux/drivers/net/8139too.c.orig Fri Dec 21 12:41:54 2001
+++ linux/drivers/net/8139too.c Wed Jan 9 20:19:43 2002
@@ -1643,7 +1643,6 @@

if (likely(len < TX_BUF_SIZE)) {
skb_copy_and_csum_dev(skb, tp->tx_buf[entry]);
- dev_kfree_skb(skb);
} else {
dev_kfree_skb(skb);
tp->stats.tx_dropped++;
@@ -1667,6 +1666,7 @@
DPRINTK ("%s: Queued Tx packet size %u to slot %d.\n",
dev->name, len, entry);

+ dev_kfree_skb(skb);
return 0;
}


--
Balazs Pozsar.

2002-01-09 19:55:24

by Andreas Dilger

Subject: Re: [PATCH] 8139too: too early dev_kfree_skb

On Jan 09, 2002 20:35 +0100, Pozsar Balazs wrote:
> This patch was originally sent to lkml on nov 30, 2001, from
> <[email protected]>, but it is not in 2.4.18-pre2.
>
> Was it just overlooked, or is it unneccessary?

I seem to recall that it was solved differently. Please read the whole
thread.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

2002-01-18 05:17:25

by Jeff Garzik

Subject: Re: [PATCH] 8139too: too early dev_kfree_skb

Andreas Dilger wrote:
>
> On Jan 09, 2002 20:35 +0100, Pozsar Balazs wrote:
> > This patch was originally sent to lkml on nov 30, 2001, from
> > <[email protected]>, but it is not in 2.4.18-pre2.
> >
> > Was it just overlooked, or is it unneccessary?
>
> I seem to recall that it was solved differently. Please read the whole
> thread.

And IIRC you were the one that solved it differently :)

--
Jeff Garzik | Alternate titles for LOTR:
Building 1024 | Fast Times at Uruk-Hai
MandrakeSoft | The Took, the Elf, His Daughter and Her Lover
| Samwise Gamgee: International Hobbit of Mystery