2008-06-15 22:17:30

by Adrian Bunk

[permalink] [raw]
Subject: sh/boards/se/770x/io.c: suspicious code

sh_pcic_io_start and sh_pcic_io_stop are used as lower and upper limits
for ports but never set to any non-zero value.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2008-06-18 09:20:33

by Nobuhiro Iwamatsu

[permalink] [raw]
Subject: Re: sh/boards/se/770x/io.c: suspicious code

Hi, Adrian.

Adrian Bunk wrote:
> sh_pcic_io_start and sh_pcic_io_stop are used as lower and upper limits
> for ports but never set to any non-zero value.

This code is used from linux-2.4 very old.
Mrshpc_ss.c(pcmcia socket driver) used sh_pcic_io_start in linux-2.4.
This driver doesn't exist now. The place where you are pointing it out
might already be unnecessary. I will send the patch to clean it.

Best regards,
Nobuhiro