2008-06-25 14:40:23

by Martin Schwidefsky

Subject: [patch 21/21] Cleanup lcs printk messages.

From: Klaus-D. Wacker <[email protected]>

Cc: Jeff Garzik <[email protected]>
Signed-off-by: Klaus-D. Wacker <[email protected]>
Signed-off-by: Martin Schwidefsky <[email protected]>
---

drivers/s390/net/lcs.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

Index: quilt-2.6/drivers/s390/net/lcs.c
===================================================================
--- quilt-2.6.orig/drivers/s390/net/lcs.c
+++ quilt-2.6/drivers/s390/net/lcs.c
@@ -1762,7 +1762,7 @@ lcs_get_control(struct lcs_card *card, s
netif_carrier_off(card->dev);
break;
default:
- PRINT_INFO("UNRECOGNIZED LGW COMMAND\n");
+ LCS_DBF_TEXT(5, trace, "noLGWcmd");
break;
}
} else
@@ -2043,13 +2043,12 @@ lcs_probe_device(struct ccwgroup_device
LCS_DBF_TEXT(2, setup, "add_dev");
card = lcs_alloc_card();
if (!card) {
- PRINT_ERR("Allocation of lcs card failed\n");
+ LCS_DBF_TEXT_(2, setup, " rc%d", -ENOMEM);
put_device(&ccwgdev->dev);
return -ENOMEM;
}
ret = sysfs_create_group(&ccwgdev->dev.kobj, &lcs_attr_group);
if (ret) {
- PRINT_ERR("Creating attributes failed");
lcs_free_card(card);
put_device(&ccwgdev->dev);
return ret;
@@ -2141,7 +2140,6 @@ lcs_new_device(struct ccwgroup_device *c
default:
LCS_DBF_TEXT(3, setup, "errinit");
PRINT_ERR("LCS: Initialization failed\n");
- PRINT_ERR("LCS: No device found!\n");
goto out;
}
if (!dev)
@@ -2270,7 +2268,6 @@ lcs_remove_device(struct ccwgroup_device
if (!card)
return;

- PRINT_INFO("Removing lcs group device ....\n");
LCS_DBF_TEXT(3, setup, "remdev");
LCS_DBF_HEX(3, setup, &card, sizeof(void*));
if (ccwgdev->state == CCWGROUP_ONLINE) {

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.

2008-06-27 04:54:57

by Jeff Garzik

Subject: Re: [patch 21/21] Cleanup lcs printk messages.

Martin Schwidefsky wrote:
> From: Klaus-D. Wacker <[email protected]>
>
> Cc: Jeff Garzik <[email protected]>
> Signed-off-by: Klaus-D. Wacker <[email protected]>
> Signed-off-by: Martin Schwidefsky <[email protected]>

ACK patches 19-21

I presume these will go upstream alongside the rest of the series..?

2008-06-27 07:02:03

by Martin Schwidefsky

Subject: Re: [patch 21/21] Cleanup lcs printk messages.

On Fri, 2008-06-27 at 00:54 -0400, Jeff Garzik wrote:
> Martin Schwidefsky wrote:
> > From: Klaus-D. Wacker <[email protected]>
> >
> > Cc: Jeff Garzik <[email protected]>
> > Signed-off-by: Klaus-D. Wacker <[email protected]>
> > Signed-off-by: Martin Schwidefsky <[email protected]>
>
> ACK patches 19-21

Good.

> I presume these will go upstream alongside the rest of the series..?

That would be the easiest, wouldn't it? I can push the whole series over
git390.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.

2008-06-27 07:09:13

by Jeff Garzik

Subject: Re: [patch 21/21] Cleanup lcs printk messages.

Martin Schwidefsky wrote:
> On Fri, 2008-06-27 at 00:54 -0400, Jeff Garzik wrote:
>> Martin Schwidefsky wrote:
>>> From: Klaus-D. Wacker <[email protected]>
>>>
>>> Cc: Jeff Garzik <[email protected]>
>>> Signed-off-by: Klaus-D. Wacker <[email protected]>
>>> Signed-off-by: Martin Schwidefsky <[email protected]>
>> ACK patches 19-21
>
> Good.
>
>> I presume these will go upstream alongside the rest of the series..?
>
> That would be the easiest, wouldn't it? I can push the whole series over
> git390.

OK by me, thanks.

Jeff