2008-07-01 08:29:29

by Eugene Teo

Subject: [PATCH] hamradio: add missing sanity check to tty operation

Add missing sanity check to tty operation.

Cc: Alan Cox <[email protected]>
Signed-off-by: Eugene Teo <[email protected]>
---
drivers/net/hamradio/mkiss.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c
index 6516603..cdebc09 100644
--- a/drivers/net/hamradio/mkiss.c
+++ b/drivers/net/hamradio/mkiss.c
@@ -546,7 +546,7 @@ static int ax_xmit(struct sk_buff *skb, struct net_device *dev)
}

printk(KERN_ERR "mkiss: %s: transmit timed out, %s?\n", dev->name,
- (ax->tty->ops->chars_in_buffer(ax->tty) || ax->xleft) ?
+ (tty_chars_in_buffer(ax->tty) || ax->xleft) ?
"bad line quality" : "driver error");

ax->xleft = 0;
--
1.5.5.1

2008-07-01 10:05:46

by Alan

Subject: Re: [PATCH] hamradio: add missing sanity check to tty operation

On Tue, 1 Jul 2008 09:28:00 +0100
Eugene Teo <[email protected]> wrote:

> Add missing sanity check to tty operation.
>
> Cc: Alan Cox <[email protected]>
> Signed-off-by: Eugene Teo <[email protected]>

Acked-by: Alan Cox <[email protected]>