2008-07-02 13:25:19

by Darren Jenkins

Subject: [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c

G'day people

Coverity CID: 2265 NEGATIVE_RETURNS

"rate" is of an unsigned type, and the code requires a signed type.
The following patch makes it so.

Only compile tested.

Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>

diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
index 62a3d8f..31d38cd 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
@@ -449,7 +449,7 @@ static void iwl3945_dbg_report_frame(struct iwl3945_priv *priv,

if (print_summary) {
char *title;
- u32 rate;
+ int rate;

if (hundred)
title = "100Frames";

2008-07-02 14:31:20

by Filippo Zangheri

Subject: Re: [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c

(Cc'ing linux-wireless)

On 02/07/2008 03:37, Darren Jenkins\ wrote:
> G'day people
>
> Coverity CID: 2265 NEGATIVE_RETURNS
>
> "rate" is of an unsigned type, and the code requires a signed type.
> The following patch makes it so.
>
> Only compile tested.
>
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index 62a3d8f..31d38cd 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -449,7 +449,7 @@ static void iwl3945_dbg_report_frame(struct iwl3945_priv *priv,
>
> if (print_summary) {
> char *title;
> - u32 rate;
> + int rate;
>
> if (hundred)
> title = "100Frames";

--
Filippo Zangheri

GPG key ID: 0x6C1F2F2F

2008-07-02 19:47:33

by John W. Linville

Subject: Re: [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c

What about the format line in the IWL_DEBUG_RX that uses rate?

Also, please use an email subject that is more descriptive than just
the filename. You should probably drop the "G'day..." line as well.

Thanks!

John

On Wed, Jul 02, 2008 at 11:37:27AM +1000, Darren Jenkins" wrote:
> G'day people
>
> Coverity CID: 2265 NEGATIVE_RETURNS
>
> "rate" is of an unsigned type, and the code requires a signed type.
> The following patch makes it so.
>
> Only compile tested.
>
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index 62a3d8f..31d38cd 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -449,7 +449,7 @@ static void iwl3945_dbg_report_frame(struct iwl3945_priv *priv,
>
> if (print_summary) {
> char *title;
> - u32 rate;
> + int rate;
>
> if (hundred)
> title = "100Frames";
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
John W. Linville
[email protected]

2008-07-03 07:03:47

by Zhu Yi

Subject: Re: [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c

On Wed, 2008-07-02 at 15:24 -0400, John W. Linville wrote:
> What about the format line in the IWL_DEBUG_RX that uses rate?
>
> Also, please use an email subject that is more descriptive than just
> the filename. You should probably drop the "G'day..." line as well.

Side with John.

> On Wed, Jul 02, 2008 at 11:37:27AM +1000, Darren Jenkins" wrote:
> > G'day people
> >
> > Coverity CID: 2265 NEGATIVE_RETURNS
> >
> > "rate" is of an unsigned type, and the code requires a signed type.
> > The following patch makes it so.
> >
> > Only compile tested.
> >
> > Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
> >
> > diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> > index 62a3d8f..31d38cd 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> > @@ -449,7 +449,7 @@ static void iwl3945_dbg_report_frame(struct iwl3945_priv *priv,
> >
> > if (print_summary) {
> > char *title;
> > - u32 rate;
> > + int rate;
> >
> > if (hundred)
> > title = "100Frames";

The rate variable here takes two roles: one for calculate the index
(singed) and the other for the actual rate (unsigned). I think if you do
want to fix this, create another local variable int idx to hold the
index result.

Thanks,
-yi