2008-07-25 11:50:55

by Vesa-Matti J Kari

[permalink] [raw]
Subject: [PATCH] audit: control character detection was off-by-one

0x7f, the DEL character, was not recognized as a control character.

Signed-off-by: Vesa-Matti Kari <[email protected]>
---
kernel/audit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index e092f1c..6d90318 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1366,7 +1366,7 @@ int audit_string_contains_control(const char *string, size_t len)
{
const unsigned char *p;
for (p = string; p < (const unsigned char *)string + len && *p; p++) {
- if (*p == '"' || *p < 0x21 || *p > 0x7f)
+ if (*p == '"' || *p < 0x21 || *p > 0x7e)
return 1;
}
return 0;
--
1.5.4.1