2008-07-28 15:28:14

by Adrian Bunk

Subject: [2.6 patch] asm-generic/gpio.h must #include <linux/errno.h>

This patch fixes the following build error:

<-- snip -->

...
CC arch/mips/kernel/gpio_txx9.o
In file included from
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-mips/mach-generic/gpio.h:19,
from include2/asm/gpio.h:4,
from /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/gpio.h:7,
from /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/kernel/gpio_txx9.c:13:
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/gpio.h: In function 'gpio_export':
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/gpio.h:163: error: 'ENOSYS' undeclared (first use in this function)
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/gpio.h:163: error: (Each undeclared identifier is reported only once
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/gpio.h:163: error: for each function it appears in.)
make[2]: *** [arch/mips/kernel/gpio_txx9.o] Error 1

<-- snip -->

Reported-by: Adrian Bunk <[email protected]>
Signed-off-by: Adrian Bunk <[email protected]>

---
ae0b61bdf413151d7587e9488c8e60dd3ff8f20d
diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
index c764a8f..0f99ad3 100644
--- a/include/asm-generic/gpio.h
+++ b/include/asm-generic/gpio.h
@@ -2,6 +2,7 @@
#define _ASM_GENERIC_GPIO_H

#include <linux/types.h>
+#include <linux/errno.h>

#ifdef CONFIG_GPIOLIB

2008-07-28 18:08:20

by David Brownell

Subject: Re: [2.6 patch] asm-generic/gpio.h must #include <linux/errno.h>

On Monday 28 July 2008, Adrian Bunk wrote:
> ? CC ? ? ?arch/mips/kernel/gpio_txx9.o
> In file included from
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-mips/mach-generic/gpio.h:19,
> ? ? ? ? ? ? ? ? ?from include2/asm/gpio.h:4,
> ? ? ? ? ? ? ? ? ?from /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/gpio.h:7,
> ? ? ? ? ? ? ? ? ?from /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/kernel/gpio_txx9.c:13:
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/gpio.h: In function 'gpio_export':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/gpio.h:163: error: 'ENOSYS' undeclared (first use in this function)
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/gpio.h:163: error: (Each undeclared identifier is reported only once
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/gpio.h:163: error: for each function it appears in.)
> make[2]: *** [arch/mips/kernel/gpio_txx9.o] Error 1

A similar patch from Atsushi Nemoto landed in my inbox 11 minutes
before yours ... so his gets the ack! ;)