2008-07-29 06:59:32

by Alexander Beregalov

Subject: sparc64: build failure at sys_sparc32.c

Hi

I am testing build using randconfig.

arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_chown16':
arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of
function 'low2highuid'
arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of
function 'low2highgid'
arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresuid16':
arch/sparc64/kernel/sys_sparc32.c:106: error: implicit declaration of
function 'high2lowuid'
arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresgid16':
arch/sparc64/kernel/sys_sparc32.c:123: error: implicit declaration of
function 'high2lowgid'

These functions are defined in linux/highuid.h only if CONFIG_UID16 is enabled.

2008-07-29 07:13:15

by David Miller

Subject: Re: sparc64: build failure at sys_sparc32.c

From: Alexander Beregalov <[email protected]>
Date: Tue, 29 Jul 2008 10:59:14 +0400

> I am testing build using randconfig.
>
> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_chown16':
> arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of
> function 'low2highuid'
> arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of
> function 'low2highgid'
> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresuid16':
> arch/sparc64/kernel/sys_sparc32.c:106: error: implicit declaration of
> function 'high2lowuid'
> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresgid16':
> arch/sparc64/kernel/sys_sparc32.c:123: error: implicit declaration of
> function 'high2lowgid'
>
> These functions are defined in linux/highuid.h only if CONFIG_UID16 is enabled.

Thanks, what kernel version is this?

2008-07-29 08:38:49

by Alexander Beregalov

Subject: Re: sparc64: build failure at sys_sparc32.c

2008/7/29 David Miller <[email protected]>:
> From: Alexander Beregalov <[email protected]>
> Date: Tue, 29 Jul 2008 10:59:14 +0400
>
>> I am testing build using randconfig.
>>
>> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_chown16':
>> arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of
>> function 'low2highuid'
>> arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of
>> function 'low2highgid'
>> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresuid16':
>> arch/sparc64/kernel/sys_sparc32.c:106: error: implicit declaration of
>> function 'high2lowuid'
>> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresgid16':
>> arch/sparc64/kernel/sys_sparc32.c:123: error: implicit declaration of
>> function 'high2lowgid'
>>
>> These functions are defined in linux/highuid.h only if CONFIG_UID16 is enabled.
>
> Thanks, what kernel version is this?

It is current by default - .27-rc1. These files were not touched for a
long time.
But, OK, I will mention the kernel version every time.

2008-08-04 01:19:43

by David Miller

Subject: Re: sparc64: build failure at sys_sparc32.c

From: "Alexander Beregalov" <[email protected]>
Date: Tue, 29 Jul 2008 12:38:38 +0400

> 2008/7/29 David Miller <[email protected]>:
> > From: Alexander Beregalov <[email protected]>
> > Date: Tue, 29 Jul 2008 10:59:14 +0400
> >
> >> I am testing build using randconfig.
> >>
> >> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_chown16':
> >> arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of
> >> function 'low2highuid'
> >> arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of
> >> function 'low2highgid'
> >> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresuid16':
> >> arch/sparc64/kernel/sys_sparc32.c:106: error: implicit declaration of
> >> function 'high2lowuid'
> >> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresgid16':
> >> arch/sparc64/kernel/sys_sparc32.c:123: error: implicit declaration of
> >> function 'high2lowgid'
> >>
> >> These functions are defined in linux/highuid.h only if CONFIG_UID16 is enabled.
> >
> > Thanks, what kernel version is this?
>
> It is current by default - .27-rc1. These files were not touched for a
> long time.
> But, OK, I will mention the kernel version every time.

This is basically setup to fail.

If SPARC64 && COMPAT this option should always be set. But it's
left as an option the user can still disable in this case down
in init/Kconfig.

This can be triggered very likely on other platforms too.

Can someone take a look at fixing this properly? Make it something
that is selected on necessary platforms, for example.

2008-08-04 14:06:59

by Adrian Bunk

Subject: Re: sparc64: build failure at sys_sparc32.c

On Sun, Aug 03, 2008 at 06:19:34PM -0700, David Miller wrote:
> From: "Alexander Beregalov" <[email protected]>
> Date: Tue, 29 Jul 2008 12:38:38 +0400
>
> > 2008/7/29 David Miller <[email protected]>:
> > > From: Alexander Beregalov <[email protected]>
> > > Date: Tue, 29 Jul 2008 10:59:14 +0400
> > >
> > >> I am testing build using randconfig.
> > >>
> > >> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_chown16':
> > >> arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of
> > >> function 'low2highuid'
> > >> arch/sparc64/kernel/sys_sparc32.c:63: error: implicit declaration of
> > >> function 'low2highgid'
> > >> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresuid16':
> > >> arch/sparc64/kernel/sys_sparc32.c:106: error: implicit declaration of
> > >> function 'high2lowuid'
> > >> arch/sparc64/kernel/sys_sparc32.c: In function 'sys32_getresgid16':
> > >> arch/sparc64/kernel/sys_sparc32.c:123: error: implicit declaration of
> > >> function 'high2lowgid'
> > >>
> > >> These functions are defined in linux/highuid.h only if CONFIG_UID16 is enabled.
> > >
> > > Thanks, what kernel version is this?
> >
> > It is current by default - .27-rc1. These files were not touched for a
> > long time.
> > But, OK, I will mention the kernel version every time.
>
> This is basically setup to fail.
>
> If SPARC64 && COMPAT this option should always be set. But it's
> left as an option the user can still disable in this case down
> in init/Kconfig.
>
> This can be triggered very likely on other platforms too.
>
> Can someone take a look at fixing this properly? Make it something
> that is selected on necessary platforms, for example.

The only platforms that do their own stuff instead of using the
functions from kernel/uid16.c are sparc64 and s390.

Is there any reason why sparc64 has it's own functions?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2008-08-07 05:53:47

by David Miller

Subject: Re: sparc64: build failure at sys_sparc32.c

From: Adrian Bunk <[email protected]>
Date: Mon, 4 Aug 2008 17:05:32 +0300

> The only platforms that do their own stuff instead of using the
> functions from kernel/uid16.c are sparc64 and s390.
>
> Is there any reason why sparc64 has it's own functions?

Thanks for pointing it out, I'll take advantage of those helper
routines.