2008-08-02 08:25:25

by Alexander Beregalov

Subject: [PATCH] proc: fix warnings

From: Alexander Beregalov <[email protected]>

proc: fix warnings

fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
unsigned int', but argument 3 has type 'u64'
fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
unsigned int', but argument 4 has type 'u64'
fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
unsigned int', but argument 5 has type 'u64'
fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
unsigned int', but argument 6 has type 'u64'
fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
unsigned int', but argument 7 has type 'u64'
fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
unsigned int', but argument 8 has type 'u64'
fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
unsigned int', but argument 9 has type 'u64'


Signed-off-by: Alexander Beregalov <[email protected]>
Cc: Andrea Righi <[email protected]>
Cc: Oleg Nesterov <[email protected]>

---

fs/proc/base.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 01ed610..a28840b 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -2423,10 +2423,13 @@ static int do_io_accounting(struct task_struct *task, char *buffer, int whole)
"read_bytes: %llu\n"
"write_bytes: %llu\n"
"cancelled_write_bytes: %llu\n",
- acct.rchar, acct.wchar,
- acct.syscr, acct.syscw,
- acct.read_bytes, acct.write_bytes,
- acct.cancelled_write_bytes);
+ (unsigned long long)acct.rchar,
+ (unsigned long long)acct.wchar,
+ (unsigned long long)acct.syscr,
+ (unsigned long long)acct.syscw,
+ (unsigned long long)acct.read_bytes,
+ (unsigned long long)acct.write_bytes,
+ (unsigned long long)acct.cancelled_write_bytes);
}

static int proc_tid_io_accounting(struct task_struct *task, char *buffer)

2008-08-02 08:50:36

by Andrea Righi

Subject: Re: [PATCH] proc: fix warnings

Alexander Beregalov wrote:
> From: Alexander Beregalov <[email protected]>
>
> proc: fix warnings
>
> fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
> unsigned int', but argument 3 has type 'u64'
> fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
> unsigned int', but argument 4 has type 'u64'
> fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
> unsigned int', but argument 5 has type 'u64'
> fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
> unsigned int', but argument 6 has type 'u64'
> fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
> unsigned int', but argument 7 has type 'u64'
> fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
> unsigned int', but argument 8 has type 'u64'
> fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
> unsigned int', but argument 9 has type 'u64'

right, my bad.

Acked-by: Andrea Righi <[email protected]>

Thanks!
-Andrea