2008-08-02 18:55:37

by Gustavo F. Padovan

Subject: [PATCH 0/3] drivers/net: 8390* cleanups

Theses patches contain cleanups to drivers/net/8390p.c and drivers/net/8390.c

2008-08-02 18:55:52

by Gustavo F. Padovan

Subject: [PATCH 1/3] drivers/net: Remove 'return' of void function NS8390p_init()

We don't need this into a void function.

Signed-off-by: Gustavo F. Padovan <[email protected]>
---
drivers/net/8390p.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/8390p.c b/drivers/net/8390p.c
index 71f1988..fd46f6c 100644
--- a/drivers/net/8390p.c
+++ b/drivers/net/8390p.c
@@ -39,7 +39,7 @@ struct net_device *__alloc_eip_netdev(int size)

void NS8390p_init(struct net_device *dev, int startp)
{
- return __NS8390_init(dev, startp);
+ __NS8390_init(dev, startp);
}

EXPORT_SYMBOL(eip_open);
--
1.5.4.5

2008-08-02 18:56:13

by Gustavo F. Padovan

Subject: [PATCH 3/3] drivers/net: coding styles fixes to drivers/net/8390.c

Fix all errors and warnings reported by checkpatch.pl

Signed-off-by: Gustavo F. Padovan <[email protected]>
---
drivers/net/8390.c | 13 +++++--------
1 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/net/8390.c b/drivers/net/8390.c
index dc5d258..f72a2e8 100644
--- a/drivers/net/8390.c
+++ b/drivers/net/8390.c
@@ -9,42 +9,39 @@ int ei_open(struct net_device *dev)
{
return __ei_open(dev);
}
+EXPORT_SYMBOL(ei_open);

int ei_close(struct net_device *dev)
{
return __ei_close(dev);
}
+EXPORT_SYMBOL(ei_close);

irqreturn_t ei_interrupt(int irq, void *dev_id)
{
return __ei_interrupt(irq, dev_id);
}
+EXPORT_SYMBOL(ei_interrupt);

#ifdef CONFIG_NET_POLL_CONTROLLER
void ei_poll(struct net_device *dev)
{
__ei_poll(dev);
}
+EXPORT_SYMBOL(ei_poll);
#endif

struct net_device *__alloc_ei_netdev(int size)
{
return ____alloc_ei_netdev(size);
}
+EXPORT_SYMBOL(__alloc_ei_netdev);

void NS8390_init(struct net_device *dev, int startp)
{
__NS8390_init(dev, startp);
}
-
-EXPORT_SYMBOL(ei_open);
-EXPORT_SYMBOL(ei_close);
-EXPORT_SYMBOL(ei_interrupt);
-#ifdef CONFIG_NET_POLL_CONTROLLER
-EXPORT_SYMBOL(ei_poll);
-#endif
EXPORT_SYMBOL(NS8390_init);
-EXPORT_SYMBOL(__alloc_ei_netdev);

#if defined(MODULE)

--
1.5.4.5

2008-08-02 18:56:35

by Gustavo F. Padovan

Subject: [PATCH 2/3] drivers/net: coding styles fixes to drivers/net/8390p.c

Fix all errors and warnings reported by checkpatch.pl

Signed-off-by: Gustavo F. Padovan <[email protected]>
---
drivers/net/8390p.c | 17 +++++++----------
1 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/drivers/net/8390p.c b/drivers/net/8390p.c
index fd46f6c..4c6eea4 100644
--- a/drivers/net/8390p.c
+++ b/drivers/net/8390p.c
@@ -4,9 +4,9 @@ static const char version[] =
"8390p.c:v1.10cvs 9/23/94 Donald Becker ([email protected])\n";

#define ei_inb(_p) inb(_p)
-#define ei_outb(_v,_p) outb(_v,_p)
+#define ei_outb(_v, _p) outb(_v, _p)
#define ei_inb_p(_p) inb_p(_p)
-#define ei_outb_p(_v,_p) outb_p(_v,_p)
+#define ei_outb_p(_v, _p) outb_p(_v, _p)

#include "lib8390.c"

@@ -14,42 +14,39 @@ int eip_open(struct net_device *dev)
{
return __ei_open(dev);
}
+EXPORT_SYMBOL(eip_open);

int eip_close(struct net_device *dev)
{
return __ei_close(dev);
}
+EXPORT_SYMBOL(eip_close);

irqreturn_t eip_interrupt(int irq, void *dev_id)
{
return __ei_interrupt(irq, dev_id);
}
+EXPORT_SYMBOL(eip_interrupt);

#ifdef CONFIG_NET_POLL_CONTROLLER
void eip_poll(struct net_device *dev)
{
__ei_poll(dev);
}
+EXPORT_SYMBOL(eip_poll);
#endif

struct net_device *__alloc_eip_netdev(int size)
{
return ____alloc_ei_netdev(size);
}
+EXPORT_SYMBOL(__alloc_eip_netdev);

void NS8390p_init(struct net_device *dev, int startp)
{
__NS8390_init(dev, startp);
}
-
-EXPORT_SYMBOL(eip_open);
-EXPORT_SYMBOL(eip_close);
-EXPORT_SYMBOL(eip_interrupt);
-#ifdef CONFIG_NET_POLL_CONTROLLER
-EXPORT_SYMBOL(eip_poll);
-#endif
EXPORT_SYMBOL(NS8390p_init);
-EXPORT_SYMBOL(__alloc_eip_netdev);

#if defined(MODULE)

--
1.5.4.5

2008-08-07 06:24:15

by Jeff Garzik

Subject: Re: [PATCH 3/3] drivers/net: coding styles fixes to drivers/net/8390.c

Gustavo F. Padovan wrote:
> Fix all errors and warnings reported by checkpatch.pl
>
> Signed-off-by: Gustavo F. Padovan <[email protected]>
> ---
> drivers/net/8390.c | 13 +++++--------
> 1 files changed, 5 insertions(+), 8 deletions(-)

applied 1-3