From: Alexander Beregalov <[email protected]>
drivers/mtd/mtdsuper.c: fix build error
drivers/mtd/mtdsuper.c:184: error: implicit declaration of
function 'lookup_bdev'
drivers/mtd/mtdsuper.c:197: error: implicit declaration of
function 'bdput'
Introduced by commit d5686b444ff3f72808d2b3fbd58672a86cdf38e7
Signed-off-by: Alexander Beregalov <[email protected]>
Cc: Al Viro <[email protected]>
---
drivers/mtd/mtdsuper.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd/mtdsuper.c
index 9b6af7e..ec950cd 100644
--- a/drivers/mtd/mtdsuper.c
+++ b/drivers/mtd/mtdsuper.c
@@ -13,6 +13,7 @@
#include <linux/mtd/super.h>
#include <linux/namei.h>
#include <linux/ctype.h>
+#include <linux/fs.h>
/*
* compare superblocks to see if they're equivalent
On Sun, Aug 03, 2008 at 02:53:04AM +0400, Alexander Beregalov wrote:
> From: Alexander Beregalov <[email protected]>
>
> drivers/mtd/mtdsuper.c: fix build error
>
> drivers/mtd/mtdsuper.c:184: error: implicit declaration of
> function 'lookup_bdev'
> drivers/mtd/mtdsuper.c:197: error: implicit declaration of
> function 'bdput'
It already gets fs.h indirectly through linux/mtd/super.h, so while
your patch might be correct it cannot fix a compile error.
If that's with CONFIG_BLOCK=n then it's
http://bugzilla.kernel.org/show_bug.cgi?id=11225
Otherwise please send your .config .
> Introduced by commit d5686b444ff3f72808d2b3fbd58672a86cdf38e7
>
>
> Signed-off-by: Alexander Beregalov <[email protected]>
> Cc: Al Viro <[email protected]>
> ---
>
> drivers/mtd/mtdsuper.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd/mtdsuper.c
> index 9b6af7e..ec950cd 100644
> --- a/drivers/mtd/mtdsuper.c
> +++ b/drivers/mtd/mtdsuper.c
> @@ -13,6 +13,7 @@
> #include <linux/mtd/super.h>
> #include <linux/namei.h>
> #include <linux/ctype.h>
> +#include <linux/fs.h>
>
> /*
> * compare superblocks to see if they're equivalent
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
2008/8/3 Adrian Bunk <[email protected]>:
> On Sun, Aug 03, 2008 at 02:53:04AM +0400, Alexander Beregalov wrote:
>> From: Alexander Beregalov <[email protected]>
>>
>> drivers/mtd/mtdsuper.c: fix build error
>>
>> drivers/mtd/mtdsuper.c:184: error: implicit declaration of
>> function 'lookup_bdev'
>> drivers/mtd/mtdsuper.c:197: error: implicit declaration of
>> function 'bdput'
>
>
> It already gets fs.h indirectly through linux/mtd/super.h, so while
> your patch might be correct it cannot fix a compile error.
>
> If that's with CONFIG_BLOCK=n then it's
> http://bugzilla.kernel.org/show_bug.cgi?id=11225
>
> Otherwise please send your .config .
I do not have this config, I collect log from builds with randconfig
and try to fix problems.
It seems it is the same bug.
On Sun, Aug 03, 2008 at 03:40:12AM +0400, Alexander Beregalov wrote:
> 2008/8/3 Adrian Bunk <[email protected]>:
> > On Sun, Aug 03, 2008 at 02:53:04AM +0400, Alexander Beregalov wrote:
> >> From: Alexander Beregalov <[email protected]>
> >>
> >> drivers/mtd/mtdsuper.c: fix build error
> >>
> >> drivers/mtd/mtdsuper.c:184: error: implicit declaration of
> >> function 'lookup_bdev'
> >> drivers/mtd/mtdsuper.c:197: error: implicit declaration of
> >> function 'bdput'
> >
> >
> > It already gets fs.h indirectly through linux/mtd/super.h, so while
> > your patch might be correct it cannot fix a compile error.
> >
> > If that's with CONFIG_BLOCK=n then it's
> > http://bugzilla.kernel.org/show_bug.cgi?id=11225
> >
> > Otherwise please send your .config .
>
> I do not have this config, I collect log from builds with randconfig
> and try to fix problems.
>...
You must store the config of the failed builds somewhere, since
otherwise (like in this case) you cannot verify whether a patch
actually fixes a problem.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
2008/8/3 Adrian Bunk <[email protected]>:
> You must store the config of the failed builds somewhere, since
> otherwise (like in this case) you cannot verify whether a patch
> actually fixes a problem.
Right, I have changed this script.
2008/8/3 Alexander Beregalov <[email protected]>:
> 2008/8/3 Adrian Bunk <[email protected]>:
>> You must store the config of the failed builds somewhere, since
>> otherwise (like in this case) you cannot verify whether a patch
>> actually fixes a problem.
> Right, I have changed this script.
>
Yes, it is CONFIG_BLOCK=n.
Thanks.