2008-08-03 12:18:16

by Thomas Meyer

[permalink] [raw]
Subject: next-20080801: BUG in pktcdvd while mounting dvd

Greetings.

Please have a look at this bug report:

http://kerneloops.org/raw.php?rawid=47211

reverting commit 5b6155ee70e9c4d2ad7e6f514c8eee06e2711c3a fixes the
problem

commit 5b6155ee70e9c4d2ad7e6f514c8eee06e2711c3a
Author: Alan Cox <[email protected]>
Date: Fri Jul 4 09:29:16 2008 +0200

pktcdvd: push BKL down into driver

Push the lock_kernel down into the driver and switch to
unlocked_ioctl

[[email protected]: build fix]
Signed-off-by: Alan Cox <[email protected]>
Acked-by: Peter Osterlund <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>


2008-08-03 15:10:48

by Alan

[permalink] [raw]
Subject: Re: next-20080801: BUG in pktcdvd while mounting dvd

On Sun, 03 Aug 2008 14:18:04 +0200
Thomas Meyer <[email protected]> wrote:

> Greetings.
>
> Please have a look at this bug report:
>
> http://kerneloops.org/raw.php?rawid=47211
>
> reverting commit 5b6155ee70e9c4d2ad7e6f514c8eee06e2711c3a fixes the
> problem

ioctl_by_bdev is calling ioctl methods with filp = NULL which is not
valid. That in turn blocks switching to unlocked_ioctl and BKL removal so
ioctl_by_bdev urgently needs fixing.

Alan