2008-10-09 05:31:33

by Shaohua Li

Subject: [patch]fix wrong sysfs file attribute

This attribute just has write operation.

Signed-off-by: Shaohua Li <[email protected]>
---
drivers/base/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/base/memory.c
===================================================================
--- linux.orig/drivers/base/memory.c 2008-10-09 11:41:40.000000000 +0800
+++ linux/drivers/base/memory.c 2008-10-09 11:41:52.000000000 +0800
@@ -325,7 +325,7 @@ memory_probe_store(struct class *class,

return count;
}
-static CLASS_ATTR(probe, 0700, NULL, memory_probe_store);
+static CLASS_ATTR(probe, 0200, NULL, memory_probe_store);

static int memory_probe_init(void)
{

2008-10-09 15:46:07

by Randy Dunlap

Subject: Re: [patch]fix wrong sysfs file attribute

On Thu, 09 Oct 2008 13:31:22 +0800 Shaohua Li wrote:

> This attribute just has write operation.
>
> Signed-off-by: Shaohua Li <[email protected]>
> ---
> drivers/base/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/base/memory.c
> ===================================================================
> --- linux.orig/drivers/base/memory.c 2008-10-09 11:41:40.000000000 +0800
> +++ linux/drivers/base/memory.c 2008-10-09 11:41:52.000000000 +0800
> @@ -325,7 +325,7 @@ memory_probe_store(struct class *class,
>
> return count;
> }
> -static CLASS_ATTR(probe, 0700, NULL, memory_probe_store);
> +static CLASS_ATTR(probe, 0200, NULL, memory_probe_store);
>
> static int memory_probe_init(void)
> {

#include <stat.h>

+static CLASS_ATTR(probe, S_IWUSR, NULL, memory_probe_store);

is almost readable.

---
~Randy