2008-10-30 01:03:51

by Hiroshi Shimamoto

Subject: [PATCH] add include list.h in binfmts.h

From: Hiroshi Shimamoto <[email protected]>

linux_binfmt uses list_head, so list.h is needed.

Signed-off-by: Hiroshi Shimamoto <[email protected]>
---
include/linux/binfmts.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
index 7394b5b..06c1123 100644
--- a/include/linux/binfmts.h
+++ b/include/linux/binfmts.h
@@ -1,6 +1,7 @@
#ifndef _LINUX_BINFMTS_H
#define _LINUX_BINFMTS_H

+#include <linux/list.h>
#include <linux/capability.h>

struct pt_regs;
--
1.5.6

2008-11-11 00:12:53

by Andrew Morton

Subject: Re: [PATCH] add include list.h in binfmts.h

On Wed, 29 Oct 2008 18:03:26 -0700
Hiroshi Shimamoto <[email protected]> wrote:

> From: Hiroshi Shimamoto <[email protected]>
>
> linux_binfmt uses list_head, so list.h is needed.
>
> Signed-off-by: Hiroshi Shimamoto <[email protected]>
> ---
> include/linux/binfmts.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
> index 7394b5b..06c1123 100644
> --- a/include/linux/binfmts.h
> +++ b/include/linux/binfmts.h
> @@ -1,6 +1,7 @@
> #ifndef _LINUX_BINFMTS_H
> #define _LINUX_BINFMTS_H
>
> +#include <linux/list.h>
> #include <linux/capability.h>
>
> struct pt_regs;

Did this fix a build error which you were seeing?

2008-11-11 00:40:27

by Hiroshi Shimamoto

Subject: Re: [PATCH] add include list.h in binfmts.h

Andrew Morton wrote:
> On Wed, 29 Oct 2008 18:03:26 -0700
> Hiroshi Shimamoto <[email protected]> wrote:
>
>> From: Hiroshi Shimamoto <[email protected]>
>>
>> linux_binfmt uses list_head, so list.h is needed.
>>
>> Signed-off-by: Hiroshi Shimamoto <[email protected]>
>> ---
>> include/linux/binfmts.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
>> index 7394b5b..06c1123 100644
>> --- a/include/linux/binfmts.h
>> +++ b/include/linux/binfmts.h
>> @@ -1,6 +1,7 @@
>> #ifndef _LINUX_BINFMTS_H
>> #define _LINUX_BINFMTS_H
>>
>> +#include <linux/list.h>
>> #include <linux/capability.h>
>>
>> struct pt_regs;
>
> Did this fix a build error which you were seeing?

I just noticed it modifying arch/x86/kernel/signal_32.c headers.
I don't know any case to fail build kernel.

The file signal_32.c includes <linux/list.h> first, and To remove
including list.h causes a build error.


thanks,
Hiroshi Shimamoto