2008-11-05 12:35:32

by Michal Schmidt

Subject: [PATCH] selinux: recognize netlink messages for 'ip addrlabel'

In enforcing mode '/sbin/ip addrlabel' results in a SELinux error:
type=SELINUX_ERR msg=audit(1225698822.073:42): SELinux: unrecognized
netlink message type=74 for sclass=43

The problem is missing RTM_*ADDRLABEL entries in SELinux's netlink
message types table.

Reported in https://bugzilla.redhat.com/show_bug.cgi?id=469423

Signed-off-by: Michal Schmidt <[email protected]>
---
security/selinux/nlmsgtab.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c
index ff59c0c..4ed7bab 100644
--- a/security/selinux/nlmsgtab.c
+++ b/security/selinux/nlmsgtab.c
@@ -63,6 +63,9 @@ static struct nlmsg_perm nlmsg_route_perms[] =
{ RTM_GETANYCAST, NETLINK_ROUTE_SOCKET__NLMSG_READ },
{ RTM_GETNEIGHTBL, NETLINK_ROUTE_SOCKET__NLMSG_READ },
{ RTM_SETNEIGHTBL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
+ { RTM_NEWADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
+ { RTM_DELADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
+ { RTM_GETADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_READ },
};

static struct nlmsg_perm nlmsg_firewall_perms[] =
--
1.6.0.3

2008-11-05 14:07:33

by Stephen Smalley

Subject: Re: [PATCH] selinux: recognize netlink messages for 'ip addrlabel'

On Wed, 2008-11-05 at 13:35 +0100, Michal Schmidt wrote:
> In enforcing mode '/sbin/ip addrlabel' results in a SELinux error:
> type=SELINUX_ERR msg=audit(1225698822.073:42): SELinux: unrecognized
> netlink message type=74 for sclass=43
>
> The problem is missing RTM_*ADDRLABEL entries in SELinux's netlink
> message types table.
>
> Reported in https://bugzilla.redhat.com/show_bug.cgi?id=469423
>
> Signed-off-by: Michal Schmidt <[email protected]>

Acked-by: Stephen Smalley <[email protected]>

> ---
> security/selinux/nlmsgtab.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c
> index ff59c0c..4ed7bab 100644
> --- a/security/selinux/nlmsgtab.c
> +++ b/security/selinux/nlmsgtab.c
> @@ -63,6 +63,9 @@ static struct nlmsg_perm nlmsg_route_perms[] =
> { RTM_GETANYCAST, NETLINK_ROUTE_SOCKET__NLMSG_READ },
> { RTM_GETNEIGHTBL, NETLINK_ROUTE_SOCKET__NLMSG_READ },
> { RTM_SETNEIGHTBL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
> + { RTM_NEWADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
> + { RTM_DELADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
> + { RTM_GETADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_READ },
> };
>
> static struct nlmsg_perm nlmsg_firewall_perms[] =
--
Stephen Smalley
National Security Agency

2008-11-05 23:10:36

by James Morris

Subject: Re: [PATCH] selinux: recognize netlink messages for 'ip addrlabel'

On Wed, 5 Nov 2008, Michal Schmidt wrote:

> In enforcing mode '/sbin/ip addrlabel' results in a SELinux error:
> type=SELINUX_ERR msg=audit(1225698822.073:42): SELinux: unrecognized
> netlink message type=74 for sclass=43
>
> The problem is missing RTM_*ADDRLABEL entries in SELinux's netlink
> message types table.
>
> Reported in https://bugzilla.redhat.com/show_bug.cgi?id=469423
>
> Signed-off-by: Michal Schmidt <[email protected]>
> ---
> security/selinux/nlmsgtab.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)

Applied to

git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

--
James Morris
<[email protected]>