2009-01-12 11:38:54

by Trilok Soni

Subject: gpio_keys: request_irq with level triggered flags

Hi Dmitry,

>From the gpio_keys.c, I can see that request_irq is assuming all the
gpio line interrupts to be edge triggered one, but what if we have
level triggered interrupts? Doesn't this flags need to come from
platform data hooks too? So, that we can specify either
(IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING ) or (IRQF_TRIGGER_HIGH |
IRQF_TRIGGER_LOW) based on the platform data?


--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

2009-01-12 12:00:37

by Ben Dooks

Subject: Re: gpio_keys: request_irq with level triggered flags

On Mon, Jan 12, 2009 at 05:08:44PM +0530, Trilok Soni wrote:
> Hi Dmitry,
>
> >From the gpio_keys.c, I can see that request_irq is assuming all the
> gpio line interrupts to be edge triggered one, but what if we have
> level triggered interrupts? Doesn't this flags need to come from
> platform data hooks too? So, that we can specify either
> (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING ) or (IRQF_TRIGGER_HIGH |
> IRQF_TRIGGER_LOW) based on the platform data?

If you are going to change to level triggered IRQs, any active IRQs
will have to be masked until the key is release, otherwise the IRQ
handler will keep being re-entered whilst the IRQ is active.

>
> --
> ---Trilok Soni
> http://triloksoni.wordpress.com
> http://www.linkedin.com/in/triloksoni
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Ben ([email protected], http://www.fluff.org/)

'a smiley only costs 4 bytes'