2009-03-05 18:14:30

by Stefan Richter

Subject: [PATCH] firedtv: fix printk format mismatch

Eliminate
drivers/media/dvb/firewire/firedtv-avc.c: In function 'debug_fcp':
drivers/media/dvb/firewire/firedtv-avc.c:156: warning: format '%d' expects type 'int', but argument 5 has type 'size_t'

Signed-off-by: Stefan Richter <[email protected]>
---

Mauro, if you don't mind I queue it up in linux1394-2.6.git for after
2.6.29, before 2.6.30-rc1. There may be firewire subsystem related
changes of firedtv coming together until then.

drivers/media/dvb/firewire/firedtv-avc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/drivers/media/dvb/firewire/firedtv-avc.c
===================================================================
--- linux.orig/drivers/media/dvb/firewire/firedtv-avc.c
+++ linux/drivers/media/dvb/firewire/firedtv-avc.c
@@ -115,7 +115,7 @@ static const char *debug_fcp_ctype(unsig
}

static const char *debug_fcp_opcode(unsigned int opcode,
- const u8 *data, size_t length)
+ const u8 *data, int length)
{
switch (opcode) {
case AVC_OPCODE_VENDOR: break;
@@ -141,7 +141,7 @@ static const char *debug_fcp_opcode(unsi
return "Vendor";
}

-static void debug_fcp(const u8 *data, size_t length)
+static void debug_fcp(const u8 *data, int length)
{
unsigned int subunit_type, subunit_id, op;
const char *prefix = data[0] > 7 ? "FCP <- " : "FCP -> ";

--
Stefan Richter
-=====-==--= --== --=-=
http://arcgraph.de/sr/

2009-03-05 18:35:19

by Mauro Carvalho Chehab

Subject: Re: [PATCH] firedtv: fix printk format mismatch

On Thu, 5 Mar 2009 19:13:43 +0100 (CET)
Stefan Richter <[email protected]> wrote:

> Eliminate
> drivers/media/dvb/firewire/firedtv-avc.c: In function 'debug_fcp':
> drivers/media/dvb/firewire/firedtv-avc.c:156: warning: format '%d' expects type 'int', but argument 5 has type 'size_t'
>
> Signed-off-by: Stefan Richter <[email protected]>

Acked-by: Mauro Carvalho Chehab <[email protected]>
> ---
>
> Mauro, if you don't mind I queue it up in linux1394-2.6.git for after
> 2.6.29, before 2.6.30-rc1. There may be firewire subsystem related
> changes of firedtv coming together until then.

Seems fine for me.

>
> drivers/media/dvb/firewire/firedtv-avc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/drivers/media/dvb/firewire/firedtv-avc.c
> ===================================================================
> --- linux.orig/drivers/media/dvb/firewire/firedtv-avc.c
> +++ linux/drivers/media/dvb/firewire/firedtv-avc.c
> @@ -115,7 +115,7 @@ static const char *debug_fcp_ctype(unsig
> }
>
> static const char *debug_fcp_opcode(unsigned int opcode,
> - const u8 *data, size_t length)
> + const u8 *data, int length)
> {
> switch (opcode) {
> case AVC_OPCODE_VENDOR: break;
> @@ -141,7 +141,7 @@ static const char *debug_fcp_opcode(unsi
> return "Vendor";
> }
>
> -static void debug_fcp(const u8 *data, size_t length)
> +static void debug_fcp(const u8 *data, int length)
> {
> unsigned int subunit_type, subunit_id, op;
> const char *prefix = data[0] > 7 ? "FCP <- " : "FCP -> ";
>




Cheers,
Mauro