2009-03-30 20:33:16

by Alexander Beregalov

Subject: [PATCH] reiserfs: fix build breakage

fs/reiserfs/inode.c: In function 'reiserfs_new_inode':
fs/reiserfs/inode.c:1919: warning: passing argument 1 of
'reiserfs_inherit_default_acl' from incompatible pointer type
fs/reiserfs/inode.c:1919: warning: passing argument 2 of
'reiserfs_inherit_default_acl' from incompatible pointer type
fs/reiserfs/inode.c:1919: warning: passing argument 3 of
'reiserfs_inherit_default_acl' from incompatible pointer type
fs/reiserfs/inode.c:1919: error: too many arguments to function
'reiserfs_inherit_default_acl'

Signed-off-by: Alexander Beregalov <[email protected]>
---

include/linux/reiserfs_acl.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/linux/reiserfs_acl.h b/include/linux/reiserfs_acl.h
index 52240e0..8cc6575 100644
--- a/include/linux/reiserfs_acl.h
+++ b/include/linux/reiserfs_acl.h
@@ -80,7 +80,8 @@ static inline int reiserfs_acl_chmod(struct inode *inode)
}

static inline int
-reiserfs_inherit_default_acl(const struct inode *dir, struct dentry *dentry,
+reiserfs_inherit_default_acl(struct reiserfs_transaction_handle *th,
+ const struct inode *dir, struct dentry *dentry,
struct inode *inode)
{
return 0;

2009-03-30 20:46:09

by Jeff Mahoney

Subject: Re: [PATCH] reiserfs: fix build breakage

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Beregalov wrote:
> fs/reiserfs/inode.c: In function 'reiserfs_new_inode':
> fs/reiserfs/inode.c:1919: warning: passing argument 1 of
> 'reiserfs_inherit_default_acl' from incompatible pointer type
> fs/reiserfs/inode.c:1919: warning: passing argument 2 of
> 'reiserfs_inherit_default_acl' from incompatible pointer type
> fs/reiserfs/inode.c:1919: warning: passing argument 3 of
> 'reiserfs_inherit_default_acl' from incompatible pointer type
> fs/reiserfs/inode.c:1919: error: too many arguments to function
> 'reiserfs_inherit_default_acl'
>
> Signed-off-by: Alexander Beregalov <[email protected]>
> ---
>
> include/linux/reiserfs_acl.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/reiserfs_acl.h b/include/linux/reiserfs_acl.h
> index 52240e0..8cc6575 100644
> --- a/include/linux/reiserfs_acl.h
> +++ b/include/linux/reiserfs_acl.h
> @@ -80,7 +80,8 @@ static inline int reiserfs_acl_chmod(struct inode *inode)
> }
>
> static inline int
> -reiserfs_inherit_default_acl(const struct inode *dir, struct dentry *dentry,
> +reiserfs_inherit_default_acl(struct reiserfs_transaction_handle *th,
> + const struct inode *dir, struct dentry *dentry,
> struct inode *inode)
> {
> return 0;

Acked-by: Jeff Mahoney <[email protected]>

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAknRL2sACgkQLPWxlyuTD7KPRQCeKLggyevsf27KTS+CujDnR23G
2XoAnRqE0fO0PAbqmL1DSXwK3HhRxQ+2
=ed4M
-----END PGP SIGNATURE-----