Subject: [PATCH -tip] powernow-k8.c: mess cleanup

Mess cleanup in powernow_k8_acpi_pst_values() function.

Signed-off-by: Luis Henriques <[email protected]>
---
arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 16 +++++++++-------
1 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
index 4709ead..6c31f95 100644
--- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
+++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
@@ -1,3 +1,4 @@
+
/*
* (c) 2003-2006 Advanced Micro Devices, Inc.
* Your use of this code is subject to the terms and conditions of the
@@ -809,13 +810,14 @@ static void powernow_k8_acpi_pst_values(struct powernow_k8_data *data,
if (!data->acpi_data.state_count || (cpu_family == CPU_HW_PSTATE))
return;

- control = data->acpi_data.states[index].control; data->irt = (control
- >> IRT_SHIFT) & IRT_MASK; data->rvo = (control >>
- RVO_SHIFT) & RVO_MASK; data->exttype = (control
- >> EXT_TYPE_SHIFT) & EXT_TYPE_MASK;
- data->plllock = (control >> PLL_L_SHIFT) & PLL_L_MASK; data->vidmvs = 1
- << ((control >> MVS_SHIFT) & MVS_MASK); data->vstable =
- (control >> VST_SHIFT) & VST_MASK; }
+ control = data->acpi_data.states[index].control;
+ data->irt = (control >> IRT_SHIFT) & IRT_MASK;
+ data->rvo = (control >> RVO_SHIFT) & RVO_MASK;
+ data->exttype = (control >> EXT_TYPE_SHIFT) & EXT_TYPE_MASK;
+ data->plllock = (control >> PLL_L_SHIFT) & PLL_L_MASK;
+ data->vidmvs = 1 << ((control >> MVS_SHIFT) & MVS_MASK);
+ data->vstable = (control >> VST_SHIFT) & VST_MASK;
+}

static int powernow_k8_cpu_init_acpi(struct powernow_k8_data *data)
{
--
1.6.2.4


2009-04-24 14:54:30

by Dave Jones

[permalink] [raw]
Subject: Re: [PATCH -tip] powernow-k8.c: mess cleanup

On Thu, Apr 23, 2009 at 07:45:04PM +0100, Luis Henriques wrote:
> Mess cleanup in powernow_k8_acpi_pst_values() function.
>
> Signed-off-by: Luis Henriques <[email protected]>

Introduced by me in 0e64a0c982c06a6b8f5e2a7f29eb108fdf257b2f

I have no idea wtf I did there, nor how I missed it
before submitting.

Dave