2002-03-04 10:22:33

by Thomas Krennwallner

Subject: [PATCH] apm bootparam 2.4.18

Hi!

Bootparam handling in apm.c is broken. apm=on and apm=off turns APM off, no
bootparam turns apm on.

so long
Thomas

--- linux-2.4.18/arch/i386/kernel/apm.c Mon Feb 25 20:37:53 2002
+++ linux/arch/i386/kernel/apm.c Fri Mar 1 10:36:34 2002
@@ -392,7 +392,7 @@
static int got_clock_diff;
#endif
static int debug;
-static int apm_disabled = -1;
+static int apm_disabled = 0;
#ifdef CONFIG_SMP
static int power_off;
#else
@@ -1868,7 +1868,7 @@
if (realmode_power_off)
apm_info.realmode_power_off = 1;
/* User can override, but default is to trust DMI */
- if (apm_disabled != -1)
+ if (apm_disabled)
apm_info.disabled = apm_disabled;

/*

2002-03-04 20:53:39

by Thomas Hood

Subject: Re: [PATCH] apm bootparam 2.4.18

Thomas Krennwallner wrote:
> Bootparam handling in apm.c is broken. apm=on and apm=off
> turns APM off, no bootparam turns apm on.

That's not true. The existing code looks correct to me.