2009-06-16 05:40:43

by Luis R. Rodriguez

[permalink] [raw]
Subject: Volunteering for stable patch review process

I'm curious what the process is to join the group of volunteers to
review stable patches. Can't seem to find the docs for it. The only
excerpt I see is:

Review committee:

- This is made up of a number of kernel developers who have volunteered for
this task, and a few that haven't.

Luis


2009-06-16 05:37:31

by Chris Wright

[permalink] [raw]
Subject: Re: Volunteering for stable patch review process

* Luis R. Rodriguez ([email protected]) wrote:
> I'm curious what the process is to join the group of volunteers to
> review stable patches. Can't seem to find the docs for it. The only
> excerpt I see is:
>
> Review committee:
>
> - This is made up of a number of kernel developers who have volunteered for
> this task, and a few that haven't.

Just send a note (you just did) and we'll put you on the review list
(I just did).

thanks,
-chris

2009-06-16 06:10:32

by Greg KH

[permalink] [raw]
Subject: Re: Volunteering for stable patch review process

On Mon, Jun 15, 2009 at 10:37:18PM -0700, Chris Wright wrote:
> * Luis R. Rodriguez ([email protected]) wrote:
> > I'm curious what the process is to join the group of volunteers to
> > review stable patches. Can't seem to find the docs for it. The only
> > excerpt I see is:
> >
> > Review committee:
> >
> > - This is made up of a number of kernel developers who have volunteered for
> > this task, and a few that haven't.
>
> Just send a note (you just did) and we'll put you on the review list
> (I just did).

Also, the relevant text for how to join is in the 000/XXX message we
send out with every review, that contains the lines:

These patches are sent out with a number of different people on the
Cc: line. If you wish to be a reviewer, please email [email protected]
to add your name to the list. If you want to be off the reviewer list,
also email us.

thanks,

greg k-h

2009-06-16 18:33:00

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: Volunteering for stable patch review process

On Mon, Jun 15, 2009 at 10:37 PM, Chris Wright<[email protected]> wrote:
> * Luis R. Rodriguez ([email protected]) wrote:
>> I'm curious what the process is to join the group of volunteers to
>> review stable patches. Can't seem to find the docs for it. The only
>> excerpt I see is:
>>
>> Review committee:
>>
>>  - This is made up of a number of kernel developers who have volunteered for
>>    this task, and a few that haven't.
>
> Just send a note (you just did) and we'll put you on the review list
> (I just did).

OK thanks, I wasn't particularly looking to volunteer but to get info
as to how to do it. But since you've already added me, lets go through
with it -- I may at least be able to help review wireless stuff.

Luis

2009-06-16 18:43:36

by Stefan Bader

[permalink] [raw]
Subject: Re: Volunteering for stable patch review process

Luis R. Rodriguez wrote:
> On Mon, Jun 15, 2009 at 10:37 PM, Chris Wright<[email protected]> wrote:
>> * Luis R. Rodriguez ([email protected]) wrote:
>>> I'm curious what the process is to join the group of volunteers to
>>> review stable patches. Can't seem to find the docs for it. The only
>>> excerpt I see is:
>>>
>>> Review committee:
>>>
>>> - This is made up of a number of kernel developers who have volunteered for
>>> this task, and a few that haven't.
>> Just send a note (you just did) and we'll put you on the review list
>> (I just did).
>
> OK thanks, I wasn't particularly looking to volunteer but to get info
> as to how to do it. But since you've already added me, lets go through
> with it -- I may at least be able to help review wireless stuff.
>
> Luis

Ok, thanks for checking out that, Luis. I'd be interested in getting in
participating. Which was the part that made Luis ask. Could you add me too?

Thanks,
Stefan

--

When all other means of communication fail, try words!

2009-06-16 18:53:49

by Greg KH

[permalink] [raw]
Subject: Re: Volunteering for stable patch review process

On Tue, Jun 16, 2009 at 08:43:29PM +0200, Stefan Bader wrote:
> Luis R. Rodriguez wrote:
> > On Mon, Jun 15, 2009 at 10:37 PM, Chris Wright<[email protected]> wrote:
> >> * Luis R. Rodriguez ([email protected]) wrote:
> >>> I'm curious what the process is to join the group of volunteers to
> >>> review stable patches. Can't seem to find the docs for it. The only
> >>> excerpt I see is:
> >>>
> >>> Review committee:
> >>>
> >>> - This is made up of a number of kernel developers who have volunteered for
> >>> this task, and a few that haven't.
> >> Just send a note (you just did) and we'll put you on the review list
> >> (I just did).
> >
> > OK thanks, I wasn't particularly looking to volunteer but to get info
> > as to how to do it. But since you've already added me, lets go through
> > with it -- I may at least be able to help review wireless stuff.
> >
> > Luis
>
> Ok, thanks for checking out that, Luis. I'd be interested in getting in
> participating. Which was the part that made Luis ask. Could you add me too?

Now added.

Hm, we now have 17 people on the list. This might be getting a bit
messy for some email systems to have such a large CC: list, perhaps we
should look into setting up an email list, like the stable-commits list
is used.

Or perhaps we should just use the stable-commits list instead? Chris,
any thoughts?

thanks,

greg k-h

2009-06-16 19:00:23

by Chris Wright

[permalink] [raw]
Subject: Re: Volunteering for stable patch review process

* Greg KH ([email protected]) wrote:
> Hm, we now have 17 people on the list. This might be getting a bit
> messy for some email systems to have such a large CC: list, perhaps we
> should look into setting up an email list, like the stable-commits list
> is used.

Heh, was just thinking the same. Yup, think a list would be better.

> Or perhaps we should just use the stable-commits list instead? Chris,
> any thoughts?

stable-commits is good from my pov, but it's effectively read only.

thanks,
-chris

2009-06-16 19:19:55

by Greg KH

[permalink] [raw]
Subject: Re: Volunteering for stable patch review process

On Tue, Jun 16, 2009 at 12:00:03PM -0700, Chris Wright wrote:
> * Greg KH ([email protected]) wrote:
> > Hm, we now have 17 people on the list. This might be getting a bit
> > messy for some email systems to have such a large CC: list, perhaps we
> > should look into setting up an email list, like the stable-commits list
> > is used.
>
> Heh, was just thinking the same. Yup, think a list would be better.
>
> > Or perhaps we should just use the stable-commits list instead? Chris,
> > any thoughts?
>
> stable-commits is good from my pov, but it's effectively read only.

Yeah, it's also higher volume which some reviewers might not like.

Should we create "stable-review" instead?

thanks,

greg k-h

2009-06-16 20:01:01

by Chris Wright

[permalink] [raw]
Subject: Re: Volunteering for stable patch review process

* Greg KH ([email protected]) wrote:
> Should we create "stable-review" instead?

Yeah, I think so. I can chase it down if you want.

thanks,
-chris